2019-11-08 15:43:05

by Corentin LABBE

Subject: [PATCH] crypto: tcrypt: constify check alg list

this patchs constify the alg list because this list is never modified.

Signed-off-by: Corentin Labbe <[email protected]>
---
crypto/tcrypt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 83ad0b1fab30..f42f486e90e8 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -65,7 +65,7 @@ static int mode;
static u32 num_mb = 8;
static char *tvmem[TVMEMSIZE];

-static char *check[] = {
+static const char *check[] = {
"des", "md5", "des3_ede", "rot13", "sha1", "sha224", "sha256", "sm3",
"blowfish", "twofish", "serpent", "sha384", "sha512", "md4", "aes",
"cast6", "arc4", "michael_mic", "deflate", "crc32c", "tea", "xtea",
@@ -1634,7 +1634,7 @@ static void test_cipher_speed(const char *algo, int enc, unsigned int secs,

static void test_available(void)
{
- char **name = check;
+ const char **name = check;

while (*name) {
printk("alg %s ", *name);
--
2.23.0

2019-11-15 06:08:44

by Herbert Xu

Subject: Re: [PATCH] crypto: tcrypt: constify check alg list

On Fri, Nov 08, 2019 at 03:42:13PM +0000, Corentin Labbe wrote:
> this patchs constify the alg list because this list is never modified.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> crypto/tcrypt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt