2019-11-12 07:25:28

by Yue Haibing

Subject: [PATCH v2 -next] crypto: sun8i-ce - Fix memdup.cocci warnings

Use kmemdup rather than duplicating its implementation

Signed-off-by: YueHaibing <[email protected]>
---
v2: fix patch title 'sun8i-ss' -> 'sun8i-ce'
---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index f0e7c1e12da6..b6e7c346c3ae 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -396,10 +396,9 @@ int sun8i_ce_aes_setkey(struct crypto_skcipher *tfm, const u8 *key,
kfree(op->key);
}
op->keylen = keylen;
- op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);
+ op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
if (!op->key)
return -ENOMEM;
- memcpy(op->key, key, keylen);

crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);
crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);
@@ -422,10 +421,9 @@ int sun8i_ce_des3_setkey(struct crypto_skcipher *tfm, const u8 *key,
kfree(op->key);
}
op->keylen = keylen;
- op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);
+ op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
if (!op->key)
return -ENOMEM;
- memcpy(op->key, key, keylen);

crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);
crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);

2019-11-16 20:05:02

by Corentin Labbe

Subject: Re: [PATCH v2 -next] crypto: sun8i-ce - Fix memdup.cocci warnings

On Tue, Nov 12, 2019 at 07:23:14AM +0000, YueHaibing wrote:
> Use kmemdup rather than duplicating its implementation
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> v2: fix patch title 'sun8i-ss' -> 'sun8i-ce'
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>

Acked-by: Corentin Labbe <[email protected]>

Thanks