2019-11-27 08:49:48

by Gilad Ben-Yossef

[permalink] [raw]
Subject: [PATCH 0/4] crypto: ccree: fixes

Assorted fixes for the ccree driver

Gilad Ben-Yossef (2):
crypto: ccree: remove useless define
crypto: ccree: fix backlog memory leak

Hadar Gat (2):
crypto: ccree: fix typos in comments
crypto: ccree: fix typos in error msgs

drivers/crypto/ccree/cc_driver.c | 8 ++++----
drivers/crypto/ccree/cc_driver.h | 1 -
drivers/crypto/ccree/cc_fips.c | 2 +-
drivers/crypto/ccree/cc_hash.c | 2 --
drivers/crypto/ccree/cc_pm.c | 2 +-
drivers/crypto/ccree/cc_request_mgr.c | 13 +++++++------
6 files changed, 13 insertions(+), 15 deletions(-)

--
2.23.0


2019-11-27 08:50:05

by Gilad Ben-Yossef

[permalink] [raw]
Subject: [PATCH 3/4] crypto: ccree: fix typos in error msgs

From: Hadar Gat <[email protected]>

Fix some typos in error message text.

Signed-off-by: Hadar Gat <[email protected]>
Signed-off-by: Gilad Ben-Yossef <[email protected]>
---
drivers/crypto/ccree/cc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
index 929ae5b468d8..1bbe82fce4a5 100644
--- a/drivers/crypto/ccree/cc_driver.c
+++ b/drivers/crypto/ccree/cc_driver.c
@@ -465,7 +465,7 @@ static int init_cc_resources(struct platform_device *plat_dev)

rc = cc_fips_init(new_drvdata);
if (rc) {
- dev_err(dev, "CC_FIPS_INIT failed 0x%x\n", rc);
+ dev_err(dev, "cc_fips_init failed 0x%x\n", rc);
goto post_debugfs_err;
}
rc = cc_sram_mgr_init(new_drvdata);
@@ -490,13 +490,13 @@ static int init_cc_resources(struct platform_device *plat_dev)

rc = cc_buffer_mgr_init(new_drvdata);
if (rc) {
- dev_err(dev, "buffer_mgr_init failed\n");
+ dev_err(dev, "cc_buffer_mgr_init failed\n");
goto post_req_mgr_err;
}

rc = cc_pm_init(new_drvdata);
if (rc) {
- dev_err(dev, "ssi_power_mgr_init failed\n");
+ dev_err(dev, "cc_pm_init failed\n");
goto post_buf_mgr_err;
}

--
2.23.0

2019-11-27 08:50:53

by Gilad Ben-Yossef

[permalink] [raw]
Subject: [PATCH 4/4] crypto: ccree: fix backlog memory leak

Fix brown paper bag bug of not releasing backlog list item buffer
when backlog was consumed causing a memory leak when backlog is
used.

Signed-off-by: Gilad Ben-Yossef <[email protected]>
Cc: [email protected] # v4.19+
---
drivers/crypto/ccree/cc_request_mgr.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/ccree/cc_request_mgr.c b/drivers/crypto/ccree/cc_request_mgr.c
index 3ed3164820eb..a5606dc04b06 100644
--- a/drivers/crypto/ccree/cc_request_mgr.c
+++ b/drivers/crypto/ccree/cc_request_mgr.c
@@ -404,6 +404,7 @@ static void cc_proc_backlog(struct cc_drvdata *drvdata)
spin_lock(&mgr->bl_lock);
list_del(&bli->list);
--mgr->bl_len;
+ kfree(bli);
}

spin_unlock(&mgr->bl_lock);
--
2.23.0

2019-12-11 09:40:35

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 0/4] crypto: ccree: fixes

On Wed, Nov 27, 2019 at 10:49:04AM +0200, Gilad Ben-Yossef wrote:
> Assorted fixes for the ccree driver
>
> Gilad Ben-Yossef (2):
> crypto: ccree: remove useless define
> crypto: ccree: fix backlog memory leak
>
> Hadar Gat (2):
> crypto: ccree: fix typos in comments
> crypto: ccree: fix typos in error msgs
>
> drivers/crypto/ccree/cc_driver.c | 8 ++++----
> drivers/crypto/ccree/cc_driver.h | 1 -
> drivers/crypto/ccree/cc_fips.c | 2 +-
> drivers/crypto/ccree/cc_hash.c | 2 --
> drivers/crypto/ccree/cc_pm.c | 2 +-
> drivers/crypto/ccree/cc_request_mgr.c | 13 +++++++------
> 6 files changed, 13 insertions(+), 15 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt