2020-01-22 17:03:58

by Madhuparna Bhowmik

Subject: [PATCH] padata.h: Annotate parallel_data with __rcu

From: Madhuparna Bhowmik <[email protected]>

This patch fixes the following sparse errors:
kernel/padata.c:110:14: error: incompatible types in comparison expression
kernel/padata.c:520:9: error: incompatible types in comparison expression
kernel/padata.c:1000:9: error: incompatible types in comparison expression

Signed-off-by: Madhuparna Bhowmik <[email protected]>
---
include/linux/padata.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/padata.h b/include/linux/padata.h
index 23717eeaad23..72a081dd2b73 100644
--- a/include/linux/padata.h
+++ b/include/linux/padata.h
@@ -143,7 +143,7 @@ struct padata_instance {
struct hlist_node node;
struct workqueue_struct *parallel_wq;
struct workqueue_struct *serial_wq;
- struct parallel_data *pd;
+ struct parallel_data __rcu *pd;
struct padata_cpumask cpumask;
struct blocking_notifier_head cpumask_change_notifier;
struct kobject kobj;
--
2.17.1

2020-01-24 04:34:52

by Madhuparna Bhowmik

Subject: Re: [PATCH] padata.h: Annotate parallel_data with __rcu

On Thu, Jan 23, 2020 at 11:08:50AM -0500, Daniel Jordan wrote:
> [add Herbert]
>
> Hi Madhuparna,
>
> On Wed, Jan 22, 2020 at 10:32:46PM +0530, [email protected] wrote:
> > From: Madhuparna Bhowmik <[email protected]>
> >
> > This patch fixes the following sparse errors:
> > kernel/padata.c:110:14: error: incompatible types in comparison expression
> > kernel/padata.c:520:9: error: incompatible types in comparison expression
> > kernel/padata.c:1000:9: error: incompatible types in comparison expression
>
> This recent patch to padata in the cryptodev tree has fixed these sparse errors
> and is heading for mainline soon:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=bbefa1dd6a6d53537c11624752219e39959d04fb
>
Thank you for letting me know about this.

Regards,
Madhuparna

> Thanks,
> Daniel