2020-02-05 10:21:20

by Horia Geanta

Subject: [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode

When running tcrypt skcipher speed tests, logs contain things like:
testing speed of async ecb(des3_ede) (ecb(des3_ede-generic)) encryption
or:
testing speed of async ecb(aes) (ecb(aes-ce)) encryption

The algorithm implementations are sync, not async.
Fix this inaccuracy.

Fixes: 7166e589da5b6 ("7166e589da5b crypto: tcrypt - Use skcipher")
Signed-off-by: Horia Geantă <[email protected]>
---
crypto/tcrypt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index f42f486e90e8..ba0b7702f2e9 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -1514,8 +1514,8 @@ static void test_skcipher_speed(const char *algo, int enc, unsigned int secs,
return;
}

- pr_info("\ntesting speed of async %s (%s) %s\n", algo,
- get_driver_name(crypto_skcipher, tfm), e);
+ pr_info("\ntesting speed of %s %s (%s) %s\n", async ? "async" : "sync",
+ algo, get_driver_name(crypto_skcipher, tfm), e);

req = skcipher_request_alloc(tfm, GFP_KERNEL);
if (!req) {
--
2.17.1

2020-02-05 10:24:38

by Horia Geanta

Subject: Re: [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode

On 2/5/2020 12:20 PM, Horia Geant? wrote:
> When running tcrypt skcipher speed tests, logs contain things like:
> testing speed of async ecb(des3_ede) (ecb(des3_ede-generic)) encryption
> or:
> testing speed of async ecb(aes) (ecb(aes-ce)) encryption
>
> The algorithm implementations are sync, not async.
> Fix this inaccuracy.
>
> Fixes: 7166e589da5b6 ("7166e589da5b crypto: tcrypt - Use skcipher")
Just noticed the typo in the Fixes tag.
Let me know if you could fix this before applying (in case
this is the only issue with the patch), or you want me to send v2.

Thanks,
Horia

2020-02-13 09:25:46

by Herbert Xu

Subject: Re: [PATCH] crypto: tcrypt - fix printed skcipher [a]sync mode

On Wed, Feb 05, 2020 at 12:19:58PM +0200, Horia Geantă wrote:
> When running tcrypt skcipher speed tests, logs contain things like:
> testing speed of async ecb(des3_ede) (ecb(des3_ede-generic)) encryption
> or:
> testing speed of async ecb(aes) (ecb(aes-ce)) encryption
>
> The algorithm implementations are sync, not async.
> Fix this inaccuracy.
>
> Fixes: 7166e589da5b6 ("7166e589da5b crypto: tcrypt - Use skcipher")
> Signed-off-by: Horia Geantă <[email protected]>
> ---
> crypto/tcrypt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt