2020-02-05 14:08:12

by chenzhou

Subject: [PATCH -next] crypto: allwinner - remove redundant platform_get_irq error message

Function dev_err() after platform_get_irq() is redundant because
platform_get_irq() already prints an error.

Signed-off-by: Chen Zhou <[email protected]>
---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
index f72346a..3e4e4bb 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
@@ -565,10 +565,8 @@ static int sun8i_ce_probe(struct platform_device *pdev)

/* Get Non Secure IRQ */
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(ce->dev, "Cannot get CryptoEngine Non-secure IRQ\n");
+ if (irq < 0)
return irq;
- }

ce->reset = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(ce->reset)) {
--
2.7.4

2020-02-13 09:26:05

by Herbert Xu

Subject: Re: [PATCH -next] crypto: allwinner - remove redundant platform_get_irq error message

On Wed, Feb 05, 2020 at 10:01:30PM +0800, Chen Zhou wrote:
> Function dev_err() after platform_get_irq() is redundant because
> platform_get_irq() already prints an error.
>
> Signed-off-by: Chen Zhou <[email protected]>
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt