2020-06-30 13:55:27

by Geert Uytterhoeven

Subject: [PATCH] hwrng: ba431 - HW_RANDOM_BA431 should not default to y

As HW_RANDOM_BA431 does not have any platform dependency, it should not
default to enabled.

Fixes: 0289e9be5dc26d84 ("hwrng: ba431 - add support for BA431 hwrng")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/char/hw_random/Kconfig | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 7b876dfdbaafe7ad..9e91c556942b1c94 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -76,7 +76,6 @@ config HW_RANDOM_ATMEL

config HW_RANDOM_BA431
tristate "Silex Insight BA431 Random Number Generator support"
- default HW_RANDOM
help
This driver provides kernel-side support for the Random Number
Generator hardware based on Silex Insight BA431 IP.
@@ -84,8 +83,6 @@ config HW_RANDOM_BA431
To compile this driver as a module, choose M here: the
module will be called ba431-rng.

- If unsure, say Y.
-
config HW_RANDOM_BCM2835
tristate "Broadcom BCM2835/BCM63xx Random Number Generator support"
depends on ARCH_BCM2835 || ARCH_BCM_NSP || ARCH_BCM_5301X || \
--
2.17.1

2020-07-09 12:55:08

by Herbert Xu

Subject: Re: [PATCH] hwrng: ba431 - HW_RANDOM_BA431 should not default to y

On Tue, Jun 30, 2020 at 03:39:41PM +0200, Geert Uytterhoeven wrote:
> As HW_RANDOM_BA431 does not have any platform dependency, it should not
> default to enabled.
>
> Fixes: 0289e9be5dc26d84 ("hwrng: ba431 - add support for BA431 hwrng")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/char/hw_random/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt