2020-07-09 12:47:40

by Herbert Xu

Subject: [PATCH] crypto: ccp - Silence strncpy warning

This patch kills an strncpy by using strscpy instead. The name
would be silently truncated if it is too long.

Signed-off-by: Herbert Xu <[email protected]>

diff --git a/drivers/crypto/ccp/ccp-crypto-sha.c b/drivers/crypto/ccp/ccp-crypto-sha.c
index b0cc2bd73af8..2bc29736fa45 100644
--- a/drivers/crypto/ccp/ccp-crypto-sha.c
+++ b/drivers/crypto/ccp/ccp-crypto-sha.c
@@ -19,6 +19,7 @@
#include <crypto/internal/hash.h>
#include <crypto/sha.h>
#include <crypto/scatterwalk.h>
+#include <linux/string.h>

#include "ccp-crypto.h"

@@ -424,7 +425,7 @@ static int ccp_register_hmac_alg(struct list_head *head,
*ccp_alg = *base_alg;
INIT_LIST_HEAD(&ccp_alg->entry);

- strncpy(ccp_alg->child_alg, def->name, CRYPTO_MAX_ALG_NAME);
+ strscpy(ccp_alg->child_alg, def->name, CRYPTO_MAX_ALG_NAME);

alg = &ccp_alg->alg;
alg->setkey = ccp_sha_setkey;
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2020-07-09 18:18:19

by John Allen

Subject: Re: [PATCH] crypto: ccp - Silence strncpy warning

On Thu, Jul 09, 2020 at 10:44:04PM +1000, Herbert Xu wrote:
> This patch kills an strncpy by using strscpy instead. The name
> would be silently truncated if it is too long.
>
> Signed-off-by: Herbert Xu <[email protected]>

Acked-by: John Allen <[email protected]>