2020-08-18 08:06:57

by Xu Wang

Subject: [PATCH] Remove unneeded variable t1

Remove unneeded variable t1 seed_encrypt() and
seed_decrypt().

Signed-off-by: Xu Wang <[email protected]>
---
crypto/seed.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/seed.c b/crypto/seed.c
index 5e3bef3a617d..69b3058d6a32 100644
--- a/crypto/seed.c
+++ b/crypto/seed.c
@@ -366,7 +366,7 @@ static void seed_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
const __be32 *src = (const __be32 *)in;
__be32 *dst = (__be32 *)out;
- u32 x1, x2, x3, x4, t0, t1;
+ u32 x1, x2, x3, x4, t0;
const u32 *ks = ctx->keysched;

x1 = be32_to_cpu(src[0]);
@@ -404,7 +404,7 @@ static void seed_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
const __be32 *src = (const __be32 *)in;
__be32 *dst = (__be32 *)out;
- u32 x1, x2, x3, x4, t0, t1;
+ u32 x1, x2, x3, x4, t0;
const u32 *ks = ctx->keysched;

x1 = be32_to_cpu(src[0]);
--
2.17.1

2020-08-28 06:58:10

by Herbert Xu

Subject: Re: [PATCH] Remove unneeded variable t1

Xu Wang <[email protected]> wrote:
> Remove unneeded variable t1 seed_encrypt() and
> seed_decrypt().
>
> Signed-off-by: Xu Wang <[email protected]>
> ---
> crypto/seed.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/crypto/seed.c b/crypto/seed.c
> index 5e3bef3a617d..69b3058d6a32 100644
> --- a/crypto/seed.c
> +++ b/crypto/seed.c
> @@ -366,7 +366,7 @@ static void seed_encrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
> const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
> const __be32 *src = (const __be32 *)in;
> __be32 *dst = (__be32 *)out;
> - u32 x1, x2, x3, x4, t0, t1;
> + u32 x1, x2, x3, x4, t0;
> const u32 *ks = ctx->keysched;
>
> x1 = be32_to_cpu(src[0]);
> @@ -404,7 +404,7 @@ static void seed_decrypt(struct crypto_tfm *tfm, u8 *out, const u8 *in)
> const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
> const __be32 *src = (const __be32 *)in;
> __be32 *dst = (__be32 *)out;
> - u32 x1, x2, x3, x4, t0, t1;
> + u32 x1, x2, x3, x4, t0;
> const u32 *ks = ctx->keysched;
>
> x1 = be32_to_cpu(src[0]);

This doesn't even compile!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt