2020-07-31 08:25:25

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v4 08/17] crypto: sun8i-ce: move iv data to request context

On Tue, Jul 21, 2020 at 07:06:22PM +0000, Corentin Labbe wrote:
> Instead of storing IV data in the channel context, store them in the
> request context.
> Storing them in the channel structure was conceptualy wrong since they
> are per request related.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> .../allwinner/sun8i-ce/sun8i-ce-cipher.c | 27 +++++++++----------
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h | 10 ++++---
> 2 files changed, 19 insertions(+), 18 deletions(-)

This patch doesn't apply against cryptodev.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


2020-08-21 07:35:58

by Corentin LABBE

[permalink] [raw]
Subject: Re: [PATCH v4 08/17] crypto: sun8i-ce: move iv data to request context

On Fri, Jul 31, 2020 at 06:24:27PM +1000, Herbert Xu wrote:
> On Tue, Jul 21, 2020 at 07:06:22PM +0000, Corentin Labbe wrote:
> > Instead of storing IV data in the channel context, store them in the
> > request context.
> > Storing them in the channel structure was conceptualy wrong since they
> > are per request related.
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
> > ---
> > .../allwinner/sun8i-ce/sun8i-ce-cipher.c | 27 +++++++++----------
> > drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h | 10 ++++---
> > 2 files changed, 19 insertions(+), 18 deletions(-)
>
> This patch doesn't apply against cryptodev.
>

Hello

Since cryptodev now have 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()"), my serie should apply cleanly.

Thanks
Regards

2020-08-21 07:39:20

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v4 08/17] crypto: sun8i-ce: move iv data to request context

On Fri, Aug 21, 2020 at 09:35:04AM +0200, LABBE Corentin wrote:
>
> Since cryptodev now have 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()"), my serie should apply cleanly.

Please resubmit. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt