2020-10-07 12:46:33

by Cabiddu, Giovanni

Subject: [PATCH] crypto: qat - remove unused function

Remove unused function qat_dh_get_params().
This is to fix the following warning when compiling the driver with
CC=clang W=1

drivers/crypto/qat/qat_common/qat_asym_algs.c:207:34: warning: unused function 'qat_dh_get_params' [-Wunused-function]

Signed-off-by: Giovanni Cabiddu <[email protected]>
Reviewed-by: Fiona Trahe <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/crypto/qat/qat_common/qat_asym_algs.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index 846569ec9066..f112078be868 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -204,11 +204,6 @@ static unsigned long qat_dh_fn_id(unsigned int len, bool g2)
};
}

-static inline struct qat_dh_ctx *qat_dh_get_params(struct crypto_kpp *tfm)
-{
- return kpp_tfm_ctx(tfm);
-}
-
static int qat_dh_compute_value(struct kpp_request *req)
{
struct crypto_kpp *tfm = crypto_kpp_reqtfm(req);
--
2.26.2

2020-10-30 06:49:07

by Herbert Xu

Subject: Re: [PATCH] crypto: qat - remove unused function

On Wed, Oct 07, 2020 at 01:43:45PM +0100, Giovanni Cabiddu wrote:
> Remove unused function qat_dh_get_params().
> This is to fix the following warning when compiling the driver with
> CC=clang W=1
>
> drivers/crypto/qat/qat_common/qat_asym_algs.c:207:34: warning: unused function 'qat_dh_get_params' [-Wunused-function]
>
> Signed-off-by: Giovanni Cabiddu <[email protected]>
> Reviewed-by: Fiona Trahe <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> ---
> drivers/crypto/qat/qat_common/qat_asym_algs.c | 5 -----
> 1 file changed, 5 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt