2020-10-28 20:25:23

by Tom Rix

[permalink] [raw]
Subject: [PATCH] crypto: qat: remove unneeded semicolon

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/crypto/qat/qat_common/qat_algs.c | 2 +-
drivers/crypto/qat/qat_common/qat_asym_algs.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c
index d552dbcfe0a0..f5d890206e86 100644
--- a/drivers/crypto/qat/qat_common/qat_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_algs.c
@@ -103,7 +103,7 @@ static int qat_get_inter_state_size(enum icp_qat_hw_auth_algo qat_hash_alg)
return ICP_QAT_HW_SHA512_STATE1_SZ;
default:
return -EFAULT;
- };
+ }
return -EFAULT;
}

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index 846569ec9066..04f2cf769fc1 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -201,7 +201,7 @@ static unsigned long qat_dh_fn_id(unsigned int len, bool g2)
return g2 ? PKE_DH_G2_4096 : PKE_DH_4096;
default:
return 0;
- };
+ }
}

static inline struct qat_dh_ctx *qat_dh_get_params(struct crypto_kpp *tfm)
@@ -577,7 +577,7 @@ static unsigned long qat_rsa_enc_fn_id(unsigned int len)
return PKE_RSA_EP_4096;
default:
return 0;
- };
+ }
}

#define PKE_RSA_DP1_512 0x1c161b3c
@@ -606,7 +606,7 @@ static unsigned long qat_rsa_dec_fn_id(unsigned int len)
return PKE_RSA_DP1_4096;
default:
return 0;
- };
+ }
}

#define PKE_RSA_DP2_512 0x1c131b57
@@ -635,7 +635,7 @@ static unsigned long qat_rsa_dec_fn_id_crt(unsigned int len)
return PKE_RSA_DP2_4096;
default:
return 0;
- };
+ }
}

static int qat_rsa_enc(struct akcipher_request *req)
--
2.18.1


2020-11-02 11:20:39

by Cabiddu, Giovanni

[permalink] [raw]
Subject: Re: [PATCH] crypto: qat: remove unneeded semicolon

On Tue, Oct 27, 2020 at 12:04:07PM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A semicolon is not needed after a switch statement.
I rebased the patch on top of cryptodev-2.6/master as it didn't apply
after the latest patches to the qat driver and modified slightly the commit
message: /s/qat:/qat -/

----8<----
From: Tom Rix <[email protected]>
Subject: [PATCH] crypto: qat - remove unneeded semicolon

A semicolon is not needed after a switch statement.

Signed-off-by: Tom Rix <[email protected]>
[[email protected]: rebased and minor change to commit message]
Signed-off-by: Giovanni Cabiddu <[email protected]>
---
drivers/crypto/qat/qat_common/qat_algs.c | 2 +-
drivers/crypto/qat/qat_common/qat_asym_algs.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c
index a38afc61f6d2..0fab8bb8ca59 100644
--- a/drivers/crypto/qat/qat_common/qat_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_algs.c
@@ -105,7 +105,7 @@ static int qat_get_inter_state_size(enum icp_qat_hw_auth_algo qat_hash_alg)
return ICP_QAT_HW_SHA512_STATE1_SZ;
default:
return -EFAULT;
- };
+ }
return -EFAULT;
}

diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
index f112078be868..2c863d25327a 100644
--- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
+++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
@@ -201,7 +201,7 @@ static unsigned long qat_dh_fn_id(unsigned int len, bool g2)
return g2 ? PKE_DH_G2_4096 : PKE_DH_4096;
default:
return 0;
- };
+ }
}

static int qat_dh_compute_value(struct kpp_request *req)
@@ -572,7 +572,7 @@ static unsigned long qat_rsa_enc_fn_id(unsigned int len)
return PKE_RSA_EP_4096;
default:
return 0;
- };
+ }
}

#define PKE_RSA_DP1_512 0x1c161b3c
@@ -601,7 +601,7 @@ static unsigned long qat_rsa_dec_fn_id(unsigned int len)
return PKE_RSA_DP1_4096;
default:
return 0;
- };
+ }
}

#define PKE_RSA_DP2_512 0x1c131b57
@@ -630,7 +630,7 @@ static unsigned long qat_rsa_dec_fn_id_crt(unsigned int len)
return PKE_RSA_DP2_4096;
default:
return 0;
- };
+ }
}

static int qat_rsa_enc(struct akcipher_request *req)
--
2.28.0

2020-11-06 07:03:24

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: qat: remove unneeded semicolon

On Tue, Oct 27, 2020 at 12:04:07PM -0700, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/crypto/qat/qat_common/qat_algs.c | 2 +-
> drivers/crypto/qat/qat_common/qat_asym_algs.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt