2020-11-17 13:48:53

by Thara Gopinath

Subject: [PATCH 6/6] devicetree:bindings:crypto: Extend qcom-qce binding to add support for crypto engine version 5.4

Add compatible string to support v5.4 crypto engine.

Signed-off-by: Thara Gopinath <[email protected]>
---
Documentation/devicetree/bindings/crypto/qcom-qce.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
index fdd53b184ba8..ed1ede9c0acc 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.txt
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
@@ -2,7 +2,9 @@ Qualcomm crypto engine driver

Required properties:

-- compatible : should be "qcom,crypto-v5.1"
+- compatible : should be
+ "qcom,crypto-v5.1" for ipq6018
+ "qcom,crypto-v5.4" for sdm845
- reg : specifies base physical address and size of the registers map
- clocks : phandle to clock-controller plus clock-specifier pair
- clock-names : "iface" clocks register interface
--
2.25.1

2020-11-18 04:11:11

by Bjorn Andersson

Subject: Re: [PATCH 6/6] devicetree:bindings:crypto: Extend qcom-qce binding to add support for crypto engine version 5.4

On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote:

> Add compatible string to support v5.4 crypto engine.
>
> Signed-off-by: Thara Gopinath <[email protected]>

$subject should be "dt-bindings: crypto: ..." and you should try to stay
within 50 chars for the subject. So how about something like:

"dt-bindings: crypto: qcom-qce: Add v5.4 to binding"

With something like that:
Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.txt b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> index fdd53b184ba8..ed1ede9c0acc 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.txt
> @@ -2,7 +2,9 @@ Qualcomm crypto engine driver
>
> Required properties:
>
> -- compatible : should be "qcom,crypto-v5.1"
> +- compatible : should be
> + "qcom,crypto-v5.1" for ipq6018
> + "qcom,crypto-v5.4" for sdm845
> - reg : specifies base physical address and size of the registers map
> - clocks : phandle to clock-controller plus clock-specifier pair
> - clock-names : "iface" clocks register interface
> --
> 2.25.1
>