2020-11-17 13:48:09

by Thara Gopinath

Subject: [PATCH 1/6] dt-binding:clock: Add entry for crypto engine RPMH clock resource

Add clock id forc CE clock resource which is required to bring up the
crypto engine on sdm845.

Signed-off-by: Thara Gopinath <[email protected]>
---
include/dt-bindings/clock/qcom,rpmh.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/qcom,rpmh.h b/include/dt-bindings/clock/qcom,rpmh.h
index 2e6c54e65455..30111c8f7fe9 100644
--- a/include/dt-bindings/clock/qcom,rpmh.h
+++ b/include/dt-bindings/clock/qcom,rpmh.h
@@ -21,5 +21,6 @@
#define RPMH_IPA_CLK 12
#define RPMH_LN_BB_CLK1 13
#define RPMH_LN_BB_CLK1_A 14
+#define RPMH_CE_CLK 15

#endif
--
2.25.1

2020-11-18 03:58:35

by Bjorn Andersson

Subject: Re: [PATCH 1/6] dt-binding:clock: Add entry for crypto engine RPMH clock resource

On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote:

> Add clock id forc CE clock resource which is required to bring up the
> crypto engine on sdm845.
>
> Signed-off-by: Thara Gopinath <[email protected]>

$subject should have bindings in plural to match other changes and a
space after the ':'

Apart from that, things looks good.

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> include/dt-bindings/clock/qcom,rpmh.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/dt-bindings/clock/qcom,rpmh.h b/include/dt-bindings/clock/qcom,rpmh.h
> index 2e6c54e65455..30111c8f7fe9 100644
> --- a/include/dt-bindings/clock/qcom,rpmh.h
> +++ b/include/dt-bindings/clock/qcom,rpmh.h
> @@ -21,5 +21,6 @@
> #define RPMH_IPA_CLK 12
> #define RPMH_LN_BB_CLK1 13
> #define RPMH_LN_BB_CLK1_A 14
> +#define RPMH_CE_CLK 15
>
> #endif
> --
> 2.25.1
>