2021-05-29 11:05:05

by Zhen Lei

[permalink] [raw]
Subject: [PATCH v2 0/4] kernel: fix some spelling mistakes

v1 --> v2:
Split into several small patches and add fixes to header files. Since there are
so many patches after the split, only three reviewed modules and one time module
with relatively more changes are retained. The spelling mistakes on the rest of
the modules will be fixed in later versions.

The header file linux/freelist.h is only included by linux/kprobes.h, so grouped
it with kprobes.c

Zhen Lei (4):
kprobes: Fix spelling mistakes
kgdb: Fix spelling mistakes
kexec: fix a spelling mistake in comment
time: Fix spelling mistakes

include/linux/freelist.h | 2 +-
include/linux/kgdb.h | 8 ++++----
include/linux/timekeeping.h | 2 +-
include/linux/timer.h | 2 +-
kernel/debug/debug_core.c | 2 +-
kernel/debug/kdb/kdb_main.c | 8 ++++----
kernel/debug/kdb/kdb_private.h | 2 +-
kernel/kexec_core.c | 2 +-
kernel/kprobes.c | 2 +-
kernel/time/alarmtimer.c | 2 +-
kernel/time/timer.c | 4 ++--
11 files changed, 18 insertions(+), 18 deletions(-)

--
2.25.1



2021-05-29 11:05:59

by Zhen Lei

[permalink] [raw]
Subject: [PATCH v2 1/4] kprobes: Fix spelling mistakes

Fix some spelling mistakes in comments:
decrese ==> decrease
immmediately ==> immediately

Signed-off-by: Zhen Lei <[email protected]>
---
include/linux/freelist.h | 2 +-
kernel/kprobes.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/freelist.h b/include/linux/freelist.h
index fc1842b96469..1811c1f3f8cb 100644
--- a/include/linux/freelist.h
+++ b/include/linux/freelist.h
@@ -39,7 +39,7 @@ static inline void __freelist_add(struct freelist_node *node, struct freelist_he
* and a refcount increment of a node in try_get, then back up to
* something non-zero, then the refcount increment is done by the other
* thread) -- so if the CAS to add the node to the actual list fails,
- * decrese the refcount and leave the add operation to the next thread
+ * decrease the refcount and leave the add operation to the next thread
* who puts the refcount back to zero (which could be us, hence the
* loop).
*/
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index 8c0a6fdef771..d4156082d5a5 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -641,7 +641,7 @@ void wait_for_kprobe_optimizer(void)
while (!list_empty(&optimizing_list) || !list_empty(&unoptimizing_list)) {
mutex_unlock(&kprobe_mutex);

- /* this will also make optimizing_work execute immmediately */
+ /* this will also make optimizing_work execute immediately */
flush_delayed_work(&optimizing_work);
/* @optimizing_work might not have been queued yet, relax */
cpu_relax();
--
2.25.1


2021-05-29 11:06:43

by Zhen Lei

[permalink] [raw]
Subject: [PATCH v2 2/4] kgdb: Fix spelling mistakes

Fix some spelling mistakes in comments:
initalization ==> initialization
detatch ==> detach
represntation ==> representation
hexidecimal ==> hexadecimal
delimeter ==> delimiter
architecure ==> architecture

Signed-off-by: Zhen Lei <[email protected]>
---
include/linux/kgdb.h | 8 ++++----
kernel/debug/debug_core.c | 2 +-
kernel/debug/kdb/kdb_main.c | 8 ++++----
kernel/debug/kdb/kdb_private.h | 2 +-
4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
index 392a3670944c..258cdde8d356 100644
--- a/include/linux/kgdb.h
+++ b/include/linux/kgdb.h
@@ -105,9 +105,9 @@ extern int dbg_set_reg(int regno, void *mem, struct pt_regs *regs);
*/

/**
- * kgdb_arch_init - Perform any architecture specific initalization.
+ * kgdb_arch_init - Perform any architecture specific initialization.
*
- * This function will handle the initalization of any architecture
+ * This function will handle the initialization of any architecture
* specific callbacks.
*/
extern int kgdb_arch_init(void);
@@ -229,9 +229,9 @@ extern int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt);
extern int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt);

/**
- * kgdb_arch_late - Perform any architecture specific initalization.
+ * kgdb_arch_late - Perform any architecture specific initialization.
*
- * This function will handle the late initalization of any
+ * This function will handle the late initialization of any
* architecture specific callbacks. This is an optional function for
* handling things like late initialization of hw breakpoints. The
* default implementation does nothing.
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
index 4708aec492df..a1f26766eb90 100644
--- a/kernel/debug/debug_core.c
+++ b/kernel/debug/debug_core.c
@@ -1032,7 +1032,7 @@ dbg_notify_reboot(struct notifier_block *this, unsigned long code, void *x)
/*
* Take the following action on reboot notify depending on value:
* 1 == Enter debugger
- * 0 == [the default] detatch debug client
+ * 0 == [the default] detach debug client
* -1 == Do nothing... and use this until the board resets
*/
switch (kgdbreboot) {
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 622410c45da1..d8ee5647b732 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -253,7 +253,7 @@ static char *kdballocenv(size_t bytes)
* Parameters:
* match A character string representing a numeric value
* Outputs:
- * *value the unsigned long represntation of the env variable 'match'
+ * *value the unsigned long representation of the env variable 'match'
* Returns:
* Zero on success, a kdb diagnostic on failure.
*/
@@ -356,7 +356,7 @@ static void kdb_printenv(void)
* Parameters:
* arg A character string representing a numeric value
* Outputs:
- * *value the unsigned long represntation of arg.
+ * *value the unsigned long representation of arg.
* Returns:
* Zero on success, a kdb diagnostic on failure.
*/
@@ -470,7 +470,7 @@ static int kdb_check_regs(void)
* symbol name, and offset to the caller.
*
* The argument may consist of a numeric value (decimal or
- * hexidecimal), a symbol name, a register name (preceded by the
+ * hexadecimal), a symbol name, a register name (preceded by the
* percent sign), an environment variable with a numeric value
* (preceded by a dollar sign) or a simple arithmetic expression
* consisting of a symbol name, +/-, and a numeric constant value
@@ -894,7 +894,7 @@ static void parse_grep(const char *str)
* Limited to 20 tokens.
*
* Real rudimentary tokenization. Basically only whitespace
- * is considered a token delimeter (but special consideration
+ * is considered a token delimiter (but special consideration
* is taken of the '=' sign as used by the 'set' command).
*
* The algorithm used to tokenize the input string relies on
diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h
index ccbed9089808..170c69aedebb 100644
--- a/kernel/debug/kdb/kdb_private.h
+++ b/kernel/debug/kdb/kdb_private.h
@@ -64,7 +64,7 @@

/*
* KDB_MAXBPT describes the total number of breakpoints
- * supported by this architecure.
+ * supported by this architecture.
*/
#define KDB_MAXBPT 16

--
2.25.1


2021-05-29 11:07:25

by Zhen Lei

[permalink] [raw]
Subject: [PATCH v2 3/4] kexec: fix a spelling mistake in comment

alloed ==> allowed

Signed-off-by: Zhen Lei <[email protected]>
Acked-by: "Eric W. Biederman" <[email protected]>
---
kernel/kexec_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
index 4b34a9aa32bc..21d44f7ae8a8 100644
--- a/kernel/kexec_core.c
+++ b/kernel/kexec_core.c
@@ -180,7 +180,7 @@ int sanity_check_segment_list(struct kimage *image)
}

/* Verify our destination addresses do not overlap.
- * If we alloed overlapping destination addresses
+ * If we allowed overlapping destination addresses
* through very weird things can happen with no
* easy explanation as one segment stops on another.
*/
--
2.25.1


2021-06-01 23:55:44

by Masami Hiramatsu

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] kprobes: Fix spelling mistakes

On Sat, 29 May 2021 19:03:02 +0800
Zhen Lei <[email protected]> wrote:

> Fix some spelling mistakes in comments:
> decrese ==> decrease
> immmediately ==> immediately

This looks good to me.

Acked-by: Masami Hiramatsu <[email protected]>

Thanks!

>
> Signed-off-by: Zhen Lei <[email protected]>
> ---
> include/linux/freelist.h | 2 +-
> kernel/kprobes.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/freelist.h b/include/linux/freelist.h
> index fc1842b96469..1811c1f3f8cb 100644
> --- a/include/linux/freelist.h
> +++ b/include/linux/freelist.h
> @@ -39,7 +39,7 @@ static inline void __freelist_add(struct freelist_node *node, struct freelist_he
> * and a refcount increment of a node in try_get, then back up to
> * something non-zero, then the refcount increment is done by the other
> * thread) -- so if the CAS to add the node to the actual list fails,
> - * decrese the refcount and leave the add operation to the next thread
> + * decrease the refcount and leave the add operation to the next thread
> * who puts the refcount back to zero (which could be us, hence the
> * loop).
> */
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index 8c0a6fdef771..d4156082d5a5 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -641,7 +641,7 @@ void wait_for_kprobe_optimizer(void)
> while (!list_empty(&optimizing_list) || !list_empty(&unoptimizing_list)) {
> mutex_unlock(&kprobe_mutex);
>
> - /* this will also make optimizing_work execute immmediately */
> + /* this will also make optimizing_work execute immediately */
> flush_delayed_work(&optimizing_work);
> /* @optimizing_work might not have been queued yet, relax */
> cpu_relax();
> --
> 2.25.1
>
>


--
Masami Hiramatsu <[email protected]>

2021-06-17 10:19:18

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH v2 2/4] kgdb: Fix spelling mistakes

On Sat, May 29, 2021 at 07:03:03PM +0800, Zhen Lei wrote:
> Fix some spelling mistakes in comments:
> initalization ==> initialization
> detatch ==> detach
> represntation ==> representation
> hexidecimal ==> hexadecimal
> delimeter ==> delimiter
> architecure ==> architecture
>
> Signed-off-by: Zhen Lei <[email protected]>

Applied, thanks.


> ---
> include/linux/kgdb.h | 8 ++++----
> kernel/debug/debug_core.c | 2 +-
> kernel/debug/kdb/kdb_main.c | 8 ++++----
> kernel/debug/kdb/kdb_private.h | 2 +-
> 4 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
> index 392a3670944c..258cdde8d356 100644
> --- a/include/linux/kgdb.h
> +++ b/include/linux/kgdb.h
> @@ -105,9 +105,9 @@ extern int dbg_set_reg(int regno, void *mem, struct pt_regs *regs);
> */
>
> /**
> - * kgdb_arch_init - Perform any architecture specific initalization.
> + * kgdb_arch_init - Perform any architecture specific initialization.
> *
> - * This function will handle the initalization of any architecture
> + * This function will handle the initialization of any architecture
> * specific callbacks.
> */
> extern int kgdb_arch_init(void);
> @@ -229,9 +229,9 @@ extern int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt);
> extern int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt);
>
> /**
> - * kgdb_arch_late - Perform any architecture specific initalization.
> + * kgdb_arch_late - Perform any architecture specific initialization.
> *
> - * This function will handle the late initalization of any
> + * This function will handle the late initialization of any
> * architecture specific callbacks. This is an optional function for
> * handling things like late initialization of hw breakpoints. The
> * default implementation does nothing.
> diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c
> index 4708aec492df..a1f26766eb90 100644
> --- a/kernel/debug/debug_core.c
> +++ b/kernel/debug/debug_core.c
> @@ -1032,7 +1032,7 @@ dbg_notify_reboot(struct notifier_block *this, unsigned long code, void *x)
> /*
> * Take the following action on reboot notify depending on value:
> * 1 == Enter debugger
> - * 0 == [the default] detatch debug client
> + * 0 == [the default] detach debug client
> * -1 == Do nothing... and use this until the board resets
> */
> switch (kgdbreboot) {
> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
> index 622410c45da1..d8ee5647b732 100644
> --- a/kernel/debug/kdb/kdb_main.c
> +++ b/kernel/debug/kdb/kdb_main.c
> @@ -253,7 +253,7 @@ static char *kdballocenv(size_t bytes)
> * Parameters:
> * match A character string representing a numeric value
> * Outputs:
> - * *value the unsigned long represntation of the env variable 'match'
> + * *value the unsigned long representation of the env variable 'match'
> * Returns:
> * Zero on success, a kdb diagnostic on failure.
> */
> @@ -356,7 +356,7 @@ static void kdb_printenv(void)
> * Parameters:
> * arg A character string representing a numeric value
> * Outputs:
> - * *value the unsigned long represntation of arg.
> + * *value the unsigned long representation of arg.
> * Returns:
> * Zero on success, a kdb diagnostic on failure.
> */
> @@ -470,7 +470,7 @@ static int kdb_check_regs(void)
> * symbol name, and offset to the caller.
> *
> * The argument may consist of a numeric value (decimal or
> - * hexidecimal), a symbol name, a register name (preceded by the
> + * hexadecimal), a symbol name, a register name (preceded by the
> * percent sign), an environment variable with a numeric value
> * (preceded by a dollar sign) or a simple arithmetic expression
> * consisting of a symbol name, +/-, and a numeric constant value
> @@ -894,7 +894,7 @@ static void parse_grep(const char *str)
> * Limited to 20 tokens.
> *
> * Real rudimentary tokenization. Basically only whitespace
> - * is considered a token delimeter (but special consideration
> + * is considered a token delimiter (but special consideration
> * is taken of the '=' sign as used by the 'set' command).
> *
> * The algorithm used to tokenize the input string relies on
> diff --git a/kernel/debug/kdb/kdb_private.h b/kernel/debug/kdb/kdb_private.h
> index ccbed9089808..170c69aedebb 100644
> --- a/kernel/debug/kdb/kdb_private.h
> +++ b/kernel/debug/kdb/kdb_private.h
> @@ -64,7 +64,7 @@
>
> /*
> * KDB_MAXBPT describes the total number of breakpoints
> - * supported by this architecure.
> + * supported by this architecture.
> */
> #define KDB_MAXBPT 16
>
> --
> 2.25.1