2021-07-11 22:32:23

by Randy Dunlap

Subject: [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod_exit' functions to be module-specific

Rename module_init & module_exit functions that are named
"mod_init" and "mod_exit" so that they are unique in both the
System.map file and in initcall_debug output instead of showing
up as almost anonymous "mod_init".

This is helpful for debugging and in determining how long certain
module_init calls take to execute.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Christian Gromm <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
v2: no change

drivers/most/most_cdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-next-20210708.orig/drivers/most/most_cdev.c
+++ linux-next-20210708/drivers/most/most_cdev.c
@@ -486,7 +486,7 @@ static struct cdev_component comp = {
},
};

-static int __init mod_init(void)
+static int __init most_cdev_init(void)
{
int err;

@@ -518,7 +518,7 @@ dest_ida:
return err;
}

-static void __exit mod_exit(void)
+static void __exit most_cdev_exit(void)
{
struct comp_channel *c, *tmp;

@@ -534,8 +534,8 @@ static void __exit mod_exit(void)
class_destroy(comp.class);
}

-module_init(mod_init);
-module_exit(mod_exit);
+module_init(most_cdev_init);
+module_exit(most_cdev_exit);
MODULE_AUTHOR("Christian Gromm <[email protected]>");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("character device component for mostcore");

2021-07-19 06:46:20

by Christian Gromm

Subject: Re: [PATCH 4/6 v2] MOST: cdev: rename 'mod_init' & 'mod_exit' functions to be module-specific

On Sun, 2021-07-11 at 15:31 -0700, Randy Dunlap wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Rename module_init & module_exit functions that are named
> "mod_init" and "mod_exit" so that they are unique in both the
> System.map file and in initcall_debug output instead of showing
> up as almost anonymous "mod_init".
>
> This is helpful for debugging and in determining how long certain
> module_init calls take to execute.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Christian Gromm <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> ---
> v2: no change
>
> drivers/most/most_cdev.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-next-20210708.orig/drivers/most/most_cdev.c
> +++ linux-next-20210708/drivers/most/most_cdev.c
> @@ -486,7 +486,7 @@ static struct cdev_component comp = {
> },
> };
>
> -static int __init mod_init(void)
> +static int __init most_cdev_init(void)
> {
> int err;
>
> @@ -518,7 +518,7 @@ dest_ida:
> return err;
> }
>
> -static void __exit mod_exit(void)
> +static void __exit most_cdev_exit(void)
> {
> struct comp_channel *c, *tmp;
>
> @@ -534,8 +534,8 @@ static void __exit mod_exit(void)
> class_destroy(comp.class);
> }
>
> -module_init(mod_init);
> -module_exit(mod_exit);
> +module_init(most_cdev_init);
> +module_exit(most_cdev_exit);
> MODULE_AUTHOR("Christian Gromm <[email protected]>");
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("character device component for mostcore");

Acked-by: Christian Gromm ([email protected])