2021-10-21 02:16:53

by Tang Bin

Subject: [PATCH] crypto: sa2ul - Use the defined variable to clean code

Use the defined variable "dev" to make the code cleaner.

Signed-off-by: Tang Bin <[email protected]>
---
drivers/crypto/sa2ul.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index 544d7040c..bcbc38dc6 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -2412,8 +2412,7 @@ static int sa_ul_probe(struct platform_device *pdev)
pm_runtime_enable(dev);
ret = pm_runtime_resume_and_get(dev);
if (ret < 0) {
- dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__,
- ret);
+ dev_err(dev, "%s: failed to get sync: %d\n", __func__, ret);
pm_runtime_disable(dev);
return ret;
}
@@ -2435,16 +2434,16 @@ static int sa_ul_probe(struct platform_device *pdev)

sa_register_algos(dev_data);

- ret = of_platform_populate(node, NULL, NULL, &pdev->dev);
+ ret = of_platform_populate(node, NULL, NULL, dev);
if (ret)
goto release_dma;

- device_for_each_child(&pdev->dev, &pdev->dev, sa_link_child);
+ device_for_each_child(dev, dev, sa_link_child);

return 0;

release_dma:
- sa_unregister_algos(&pdev->dev);
+ sa_unregister_algos(dev);

dma_release_channel(dev_data->dma_rx2);
dma_release_channel(dev_data->dma_rx1);
@@ -2453,8 +2452,8 @@ static int sa_ul_probe(struct platform_device *pdev)
destroy_dma_pool:
dma_pool_destroy(dev_data->sc_pool);

- pm_runtime_put_sync(&pdev->dev);
- pm_runtime_disable(&pdev->dev);
+ pm_runtime_put_sync(dev);
+ pm_runtime_disable(dev);

return ret;
}
--
2.20.1.windows.1

2021-10-29 13:12:13

by Herbert Xu

Subject: Re: [PATCH] crypto: sa2ul - Use the defined variable to clean code

On Thu, Oct 21, 2021 at 10:16:23AM +0800, Tang Bin wrote:
> Use the defined variable "dev" to make the code cleaner.
>
> Signed-off-by: Tang Bin <[email protected]>
> ---
> drivers/crypto/sa2ul.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt