2021-12-04 10:47:45

by Weili Qian

Subject: [PATCH] crypto: hisilicon/qm - fix incorrect return value of hisi_qm_resume()

When hisi_qm_resume() returns 0, it indicates that the device has started
successfully. If the device fails to start, hisi_qm_resume() needs to
return the actual error code to the caller instead of 0.

Fixes: d7ea53395b72 ("crypto: hisilicon - add runtime PM ops")
Signed-off-by: Weili Qian <[email protected]>
---
drivers/crypto/hisilicon/qm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index ad706ccfe91a..896255aec87f 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -6071,7 +6071,7 @@ int hisi_qm_resume(struct device *dev)
if (ret)
pci_err(pdev, "failed to start qm(%d)\n", ret);

- return 0;
+ return ret;
}
EXPORT_SYMBOL_GPL(hisi_qm_resume);

--
2.33.0

2021-12-11 05:56:52

by Herbert Xu

Subject: Re: [PATCH] crypto: hisilicon/qm - fix incorrect return value of hisi_qm_resume()

On Sat, Dec 04, 2021 at 06:43:01PM +0800, Weili Qian wrote:
> When hisi_qm_resume() returns 0, it indicates that the device has started
> successfully. If the device fails to start, hisi_qm_resume() needs to
> return the actual error code to the caller instead of 0.
>
> Fixes: d7ea53395b72 ("crypto: hisilicon - add runtime PM ops")
> Signed-off-by: Weili Qian <[email protected]>
> ---
> drivers/crypto/hisilicon/qm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt