2022-06-09 11:27:11

by Weili Qian

Subject: [PATCH] crypto: hisilicon/trng - fix local variable type

The return value of 'readl_poll_timeout' is '0' or '-ETIMEDOUT'. Therefore,
change the local variable 'ret' type from 'u32' to 'int'.

Signed-off-by: Weili Qian <[email protected]>
---
drivers/crypto/hisilicon/trng/trng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/trng/trng.c b/drivers/crypto/hisilicon/trng/trng.c
index 829f2caf0f67..97e500db0a82 100644
--- a/drivers/crypto/hisilicon/trng/trng.c
+++ b/drivers/crypto/hisilicon/trng/trng.c
@@ -185,7 +185,7 @@ static int hisi_trng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
struct hisi_trng *trng;
int currsize = 0;
u32 val = 0;
- u32 ret;
+ int ret;

trng = container_of(rng, struct hisi_trng, rng);

--
2.33.0

2022-06-17 09:21:53

by Herbert Xu

Subject: Re: [PATCH] crypto: hisilicon/trng - fix local variable type

On Thu, Jun 09, 2022 at 07:18:19PM +0800, Weili Qian wrote:
> The return value of 'readl_poll_timeout' is '0' or '-ETIMEDOUT'. Therefore,
> change the local variable 'ret' type from 'u32' to 'int'.
>
> Signed-off-by: Weili Qian <[email protected]>
> ---
> drivers/crypto/hisilicon/trng/trng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt