2022-07-19 07:58:15

by Pali Rohár

Subject: [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of

Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
loaded on platforms where inside-secure crypto HW is specified in device
tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.

Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
Signed-off-by: Pali Rohár <[email protected]>
---
drivers/crypto/inside-secure/safexcel.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 9b1a158aec29..ad0d8c4a71ac 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1831,6 +1831,8 @@ static const struct of_device_id safexcel_of_match_table[] = {
{},
};

+MODULE_DEVICE_TABLE(of, safexcel_of_match_table);
+
static struct platform_driver crypto_safexcel = {
.probe = safexcel_probe,
.remove = safexcel_remove,
--
2.20.1

2022-07-19 08:04:42

by Marek Behún

Subject: Re: [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of

On Tue, 19 Jul 2022 09:54:03 +0200
Pali Rohár <[email protected]> wrote:

> Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
> loaded on platforms where inside-secure crypto HW is specified in device
> tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
>
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Pali Rohár <[email protected]>

Acked-by: Marek Behún <[email protected]>

2022-07-29 10:36:43

by Herbert Xu

Subject: Re: [PATCH] crypto: inside-secure: Add missing MODULE_DEVICE_TABLE for of

On Tue, Jul 19, 2022 at 09:54:03AM +0200, Pali Roh?r wrote:
> Without MODULE_DEVICE_TABLE, crypto_safexcel.ko module is not automatically
> loaded on platforms where inside-secure crypto HW is specified in device
> tree (e.g. Armada 3720). So add missing MODULE_DEVICE_TABLE for of.
>
> Fixes: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver")
> Signed-off-by: Pali Roh?r <[email protected]>
> ---
> drivers/crypto/inside-secure/safexcel.c | 2 ++
> 1 file changed, 2 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt