2022-07-23 09:43:12

by Jason Wang

[permalink] [raw]
Subject: [PATCH] crypto: tcrypt - Remove the static variable initialisations to NULL

Initialise global and static variable to NULL is always unnecessary.
Remove the unnecessary initialisations.

Signed-off-by: Jason Wang <[email protected]>
---
crypto/tcrypt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index f56d1a9cf0a7..59eb8ec36664 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -58,7 +58,7 @@
*/
static unsigned int sec;

-static char *alg = NULL;
+static char *alg;
static u32 type;
static u32 mask;
static int mode;
--
2.35.1


2022-07-29 10:41:05

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: tcrypt - Remove the static variable initialisations to NULL

On Sat, Jul 23, 2022 at 05:26:40PM +0800, Jason Wang wrote:
> Initialise global and static variable to NULL is always unnecessary.
> Remove the unnecessary initialisations.
>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> crypto/tcrypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt