2022-08-03 20:50:47

by Jean Delvare

Subject: [PATCH] crypto: keembay-ocs - Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Signed-off-by: Jean Delvare <[email protected]>
Cc: Declan Murphy <[email protected]>
Cc: Daniele Alessandrelli <[email protected]>
Cc: Mark Gross <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: Prabhjot Khurana <[email protected]>
Cc: "David S. Miller" <[email protected]>
---
drivers/crypto/keembay/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-5.18.orig/drivers/crypto/keembay/Kconfig 2022-05-22 21:52:31.000000000 +0200
+++ linux-5.18/drivers/crypto/keembay/Kconfig 2022-08-03 22:36:27.354500492 +0200
@@ -42,7 +42,7 @@ config CRYPTO_DEV_KEEMBAY_OCS_AES_SM4_CT
config CRYPTO_DEV_KEEMBAY_OCS_ECC
tristate "Support for Intel Keem Bay OCS ECC HW acceleration"
depends on ARCH_KEEMBAY || COMPILE_TEST
- depends on OF || COMPILE_TEST
+ depends on OF
depends on HAS_IOMEM
select CRYPTO_ECDH
select CRYPTO_ENGINE
@@ -64,7 +64,7 @@ config CRYPTO_DEV_KEEMBAY_OCS_HCU
select CRYPTO_ENGINE
depends on HAS_IOMEM
depends on ARCH_KEEMBAY || COMPILE_TEST
- depends on OF || COMPILE_TEST
+ depends on OF
help
Support for Intel Keem Bay Offload and Crypto Subsystem (OCS) Hash
Control Unit (HCU) hardware acceleration for use with Crypto API.


--
Jean Delvare
SUSE L3 Support

2022-08-19 11:06:37

by Herbert Xu

Subject: Re: [PATCH] crypto: keembay-ocs - Drop obsolete dependency on COMPILE_TEST

On Wed, Aug 03, 2022 at 10:47:55PM +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Declan Murphy <[email protected]>
> Cc: Daniele Alessandrelli <[email protected]>
> Cc: Mark Gross <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: Prabhjot Khurana <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> ---
> drivers/crypto/keembay/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt