2022-08-13 10:39:37

by Yang Shen

Subject: [PATCH] crypto: hisilicon/qm - remove unneeded hardware cache write back

From: Weili Qian <[email protected]>

Data in the hardware cache needs to be written back to the memory
before the queue memory is released. Currently, the queue memory is
applied for when the driver is loaded and released when the driver is
removed. Therefore, the hardware cache does not need to be written back
when process puts queue.

Signed-off-by: Weili Qian <[email protected]>
Signed-off-by: Yang Shen <[email protected]>
---
drivers/crypto/hisilicon/qm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 771ba73468f7..0f8ae8f99413 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -3258,7 +3258,6 @@ static void hisi_qm_uacce_put_queue(struct uacce_queue *q)
{
struct hisi_qp *qp = q->priv;

- hisi_qm_cache_wb(qp->qm);
hisi_qm_release_qp(qp);
}

--
2.33.0

2022-08-19 11:07:43

by Herbert Xu

Subject: Re: [PATCH] crypto: hisilicon/qm - remove unneeded hardware cache write back

On Sat, Aug 13, 2022 at 06:35:45PM +0800, Yang Shen wrote:
> From: Weili Qian <[email protected]>
>
> Data in the hardware cache needs to be written back to the memory
> before the queue memory is released. Currently, the queue memory is
> applied for when the driver is loaded and released when the driver is
> removed. Therefore, the hardware cache does not need to be written back
> when process puts queue.
>
> Signed-off-by: Weili Qian <[email protected]>
> Signed-off-by: Yang Shen <[email protected]>
> ---
> drivers/crypto/hisilicon/qm.c | 1 -
> 1 file changed, 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt