2022-11-16 09:33:21

by Zhang Yiqun

Subject: [PATCH] crypto: tcrypt - Fix multibuffer skcipher speed test mem leak

In the past, the data for mb-skcipher test has been allocated
twice, that means the first allcated memory area is without
free, which may cause a potential memory leakage. So this
patch is to remove one allocation to fix this error.

Signed-off-by: Zhang Yiqun <[email protected]>
---
crypto/tcrypt.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index a82679b576bb..4c018d8d06c8 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -1090,15 +1090,6 @@ static void test_mb_skcipher_speed(const char *algo, int enc, int secs,
goto out_free_tfm;
}

-
- for (i = 0; i < num_mb; ++i)
- if (testmgr_alloc_buf(data[i].xbuf)) {
- while (i--)
- testmgr_free_buf(data[i].xbuf);
- goto out_free_tfm;
- }
-
-
for (i = 0; i < num_mb; ++i) {
data[i].req = skcipher_request_alloc(tfm, GFP_KERNEL);
if (!data[i].req) {
--
2.17.1

2022-11-25 09:47:43

by Herbert Xu

Subject: Re: [PATCH] crypto: tcrypt - Fix multibuffer skcipher speed test mem leak

Zhang Yiqun <[email protected]> wrote:
> In the past, the data for mb-skcipher test has been allocated
> twice, that means the first allcated memory area is without
> free, which may cause a potential memory leakage. So this
> patch is to remove one allocation to fix this error.
>
> Signed-off-by: Zhang Yiqun <[email protected]>
> ---
> crypto/tcrypt.c | 9 ---------
> 1 file changed, 9 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt