2023-05-30 16:02:20

by Cabiddu, Giovanni

Subject: [PATCH] crypto: qat - set deprecated capabilities as reserved

From: Karthikeyan Gopal <[email protected]>

The LZS and RAND features are no longer available on QAT.
Remove the definition of bit 6 (LZS) and bit 7 (RAND) in the enum that
represents the capabilities and replace them with a comment mentioning
that those bits are reserved.
Those bits shall not be used in future.

Signed-off-by: Karthikeyan Gopal <[email protected]>
Reviewed-by: Giovanni Cabiddu <[email protected]>
Signed-off-by: Giovanni Cabiddu <[email protected]>
---
drivers/crypto/intel/qat/qat_common/icp_qat_hw.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/intel/qat/qat_common/icp_qat_hw.h b/drivers/crypto/intel/qat/qat_common/icp_qat_hw.h
index 4042739bb6fa..a65059e56248 100644
--- a/drivers/crypto/intel/qat/qat_common/icp_qat_hw.h
+++ b/drivers/crypto/intel/qat/qat_common/icp_qat_hw.h
@@ -87,8 +87,7 @@ enum icp_qat_capabilities_mask {
ICP_ACCEL_CAPABILITIES_AUTHENTICATION = BIT(3),
ICP_ACCEL_CAPABILITIES_RESERVED_1 = BIT(4),
ICP_ACCEL_CAPABILITIES_COMPRESSION = BIT(5),
- ICP_ACCEL_CAPABILITIES_LZS_COMPRESSION = BIT(6),
- ICP_ACCEL_CAPABILITIES_RAND = BIT(7),
+ /* Bits 6-7 are currently reserved */
ICP_ACCEL_CAPABILITIES_ZUC = BIT(8),
ICP_ACCEL_CAPABILITIES_SHA3 = BIT(9),
/* Bits 10-11 are currently reserved */
--
2.40.1

2023-06-09 09:24:33

by Herbert Xu

Subject: Re: [PATCH] crypto: qat - set deprecated capabilities as reserved

On Tue, May 30, 2023 at 04:58:11PM +0100, Giovanni Cabiddu wrote:
> From: Karthikeyan Gopal <[email protected]>
>
> The LZS and RAND features are no longer available on QAT.
> Remove the definition of bit 6 (LZS) and bit 7 (RAND) in the enum that
> represents the capabilities and replace them with a comment mentioning
> that those bits are reserved.
> Those bits shall not be used in future.
>
> Signed-off-by: Karthikeyan Gopal <[email protected]>
> Reviewed-by: Giovanni Cabiddu <[email protected]>
> Signed-off-by: Giovanni Cabiddu <[email protected]>
> ---
> drivers/crypto/intel/qat/qat_common/icp_qat_hw.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt