This patch series is aimed at addressing several dtbs_check warnings by
introducing additional support in the device tree bindings for i.MX6
series SoCs. The warnings surfaced while validating some i.MX6 boards.
The issues were predominantly around unrecognized compatibility strings
and missing properties in the device trees.
Oleksij Rempel (7):
dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support
dt-bindings: timer: gpt: Add i.MX6UL support
dt-bindings: timer: gpt: Support 3rd clock for i.MX6DL
dt-bindings: crypto: fsl-dcp: Add i.MX6SL, i.MX6SLL, and i.MX6ULL
support
dt-bindings: clock: imx6ul: Support optional enet*_ref_pad clocks
dt-bindings: clock: imx6q: Allow single optional clock and add
enet_ref_pad
dt-bindings: input: touchscreen: edt-ft5x06: Add 'threshold' property
.../bindings/clock/imx6q-clock.yaml | 15 ++++++-----
.../bindings/clock/imx6ul-clock.yaml | 6 +++++
.../devicetree/bindings/crypto/fsl-dcp.yaml | 19 +++++++++++---
.../input/touchscreen/edt-ft5x06.yaml | 6 +++++
.../bindings/mmc/fsl-imx-esdhc.yaml | 2 ++
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 26 ++++++++++++++-----
6 files changed, 59 insertions(+), 15 deletions(-)
--
2.39.2
Add a new property 'threshold' to the edt-ft5x06 touchscreen binding.
This property allows setting the "click"-threshold in the range from 0
to 255. This change addresses the following dtbs_check warning:
imx6dl-lanmcu.dtb: touchscreen@38: 'threshold' does not match any of the
regexes: 'pinctrl-[0-9]+'
From schema:
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
Signed-off-by: Oleksij Rempel <[email protected]>
---
.../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
index ef4c841387bd..f2808cb4d99d 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
@@ -93,6 +93,12 @@ properties:
minimum: 1
maximum: 255
+ threshold:
+ description: Allows setting the "click"-threshold in the range from 0 to 255.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 255
+
touchscreen-size-x: true
touchscreen-size-y: true
touchscreen-fuzz-x: true
--
2.39.2
Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt'
binding to resolve the following dtbs_check warning:
imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]]
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per']
is too long
From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
Signed-off-by: Oleksij Rempel <[email protected]>
---
.../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++-----
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
index adf617b8f353..21ff51c3f38f 100644
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
@@ -46,14 +46,24 @@ properties:
maxItems: 1
clocks:
- items:
- - description: SoC GPT ipg clock
- - description: SoC GPT per clock
+ anyOf:
+ - items:
+ - description: SoC GPT ipg clock
+ - description: SoC GPT per clock
+ - items:
+ - description: SoC GPT ipg clock
+ - description: SoC GPT per clock
+ - description: SoC GPT osc_per clock
clock-names:
- items:
- - const: ipg
- - const: per
+ anyOf:
+ - items:
+ - const: ipg
+ - const: per
+ - items:
+ - const: ipg
+ - const: per
+ - const: osc_per
required:
- compatible
--
2.39.2
Add support for i.MX6SL, i.MX6SLL, and i.MX6ULL to the 'fsl-dcp' binding
to address the following dtbs_check warning:
imx6ull-jozacp.dtb: crypto@2280000: compatible:0: 'fsl,imx6ull-dcp' is
not one of ['fsl,imx23-dcp', 'fsl,imx28-dcp']
From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
imx6ull-jozacp.dtb: crypto@2280000: compatible: ['fsl,imx6ull-dcp',
'fsl,imx28-dcp'] is too long
From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
Signed-off-by: Oleksij Rempel <[email protected]>
---
.../devicetree/bindings/crypto/fsl-dcp.yaml | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml b/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
index 99be01539fcd..8af393b9f3ca 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
@@ -11,9 +11,22 @@ maintainers:
properties:
compatible:
- enum:
- - fsl,imx23-dcp
- - fsl,imx28-dcp
+ oneOf:
+ - const: fsl,imx23-dcp
+ - const: fsl,imx28-dcp
+ - const: fsl,imx6sl-dcp
+ - const: fsl,imx6sll-dcp
+ - const: fsl,imx6ull-dcp
+ - items:
+ - enum:
+ - fsl,imx6sl-dcp
+ - fsl,imx6sll-dcp
+ - fsl,imx6ull-dcp
+ - const: fsl,imx28-dcp
+ - items:
+ - enum:
+ - fsl,imx28-dcp
+ - const: fsl,imx23-dcp
reg:
maxItems: 1
--
2.39.2
On Thu, Jun 01, 2023 at 12:14:47PM +0200, Oleksij Rempel wrote:
> Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt'
> binding to resolve the following dtbs_check warning:
> imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]]
> is too long
> From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per']
> is too long
> From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++-----
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index adf617b8f353..21ff51c3f38f 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -46,14 +46,24 @@ properties:
> maxItems: 1
>
> clocks:
> - items:
> - - description: SoC GPT ipg clock
> - - description: SoC GPT per clock
> + anyOf:
> + - items:
> + - description: SoC GPT ipg clock
> + - description: SoC GPT per clock
> + - items:
> + - description: SoC GPT ipg clock
> + - description: SoC GPT per clock
> + - description: SoC GPT osc_per clock
>
> clock-names:
> - items:
> - - const: ipg
> - - const: per
> + anyOf:
> + - items:
> + - const: ipg
> + - const: per
> + - items:
> + - const: ipg
> + - const: per
> + - const: osc_per
Hmm, should we not do per-compatible enforcement here so that the extra
clock is only used on the appropriate platforms?
Cheers,
Conor.
>
> required:
> - compatible
> --
> 2.39.2
>
On Thu, Jun 01, 2023 at 12:14:48PM +0200, Oleksij Rempel wrote:
> Add support for i.MX6SL, i.MX6SLL, and i.MX6ULL to the 'fsl-dcp' binding
> to address the following dtbs_check warning:
> imx6ull-jozacp.dtb: crypto@2280000: compatible:0: 'fsl,imx6ull-dcp' is
> not one of ['fsl,imx23-dcp', 'fsl,imx28-dcp']
> From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
>
> imx6ull-jozacp.dtb: crypto@2280000: compatible: ['fsl,imx6ull-dcp',
> 'fsl,imx28-dcp'] is too long
> From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/crypto/fsl-dcp.yaml | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml b/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> index 99be01539fcd..8af393b9f3ca 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> @@ -11,9 +11,22 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - fsl,imx23-dcp
> - - fsl,imx28-dcp
> + oneOf:
> + - const: fsl,imx23-dcp
> + - const: fsl,imx28-dcp
> + - const: fsl,imx6sl-dcp
> + - const: fsl,imx6sll-dcp
> + - const: fsl,imx6ull-dcp
Confused again here chief, why allow these to appear on their own if
their are all compatible with the imx28-dcp?
> + - items:
> + - enum:
> + - fsl,imx6sl-dcp
> + - fsl,imx6sll-dcp
> + - fsl,imx6ull-dcp
> + - const: fsl,imx28-dcp
> + - items:
> + - enum:
> + - fsl,imx28-dcp
> + - const: fsl,imx23-dcp
I don't get this either. Why set the imx23-dcp as the fallback for the
imx28-dcp, when the imx28-dcp is being used as the fallback for the imx6
stuff?
I get the impression that some of the devicetrees should be fixed up,
rather than adding these sorta odd conditions to the bindings.
To me it'd make sense to swap everything that uses imx28-dcp as a
fallback to use imx23-dcp instead, since that is the most generic one?
What am I missing?
Cheers,
Conor.
>
> reg:
> maxItems: 1
> --
> 2.39.2
>
On Thu, Jun 01, 2023 at 12:14:47PM +0200, Oleksij Rempel wrote:
> Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt'
> binding to resolve the following dtbs_check warning:
> imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]]
> is too long
> From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per']
> is too long
> From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++-----
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index adf617b8f353..21ff51c3f38f 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -46,14 +46,24 @@ properties:
> maxItems: 1
>
> clocks:
> - items:
> - - description: SoC GPT ipg clock
> - - description: SoC GPT per clock
> + anyOf:
No need for anyOf. Just add the 3rd entry and 'minItems: 2'.
> + - items:
> + - description: SoC GPT ipg clock
> + - description: SoC GPT per clock
> + - items:
> + - description: SoC GPT ipg clock
> + - description: SoC GPT per clock
> + - description: SoC GPT osc_per clock
>
> clock-names:
> - items:
> - - const: ipg
> - - const: per
> + anyOf:
> + - items:
> + - const: ipg
> + - const: per
> + - items:
> + - const: ipg
> + - const: per
> + - const: osc_per
>
> required:
> - compatible
> --
> 2.39.2
>
On Thu, 01 Jun 2023 12:14:51 +0200, Oleksij Rempel wrote:
> Add a new property 'threshold' to the edt-ft5x06 touchscreen binding.
> This property allows setting the "click"-threshold in the range from 0
> to 255. This change addresses the following dtbs_check warning:
> imx6dl-lanmcu.dtb: touchscreen@38: 'threshold' does not match any of the
> regexes: 'pinctrl-[0-9]+'
> From schema:
> Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: Rob Herring <[email protected]>