Fix the following checkpatch warning:
- WARNING: Missing or malformed SPDX-License-Identifier tag
Signed-off-by: Franziska Naepelt <[email protected]>
---
crypto/crct10dif_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/crypto/crct10dif_common.c b/crypto/crct10dif_common.c
index b2fab366f518..134553bf0d60 100644
--- a/crypto/crct10dif_common.c
+++ b/crypto/crct10dif_common.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Cryptographic API.
*
base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
--
2.39.2 (Apple Git-143)
On Tue, Jun 06, 2023 at 01:03:22PM +0200, Franziska Naepelt wrote:
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Cryptographic API.
> *
Shouldn't the license boilerplate text be also removed (and thus
completing SPDX conversion)?
Thanks.
--
An old man doll... just what I always wanted! - Clara
Fix the following checkpatch warning:
- WARNING: Missing or malformed SPDX-License-Identifier tag
Signed-off-by: Franziska Naepelt <[email protected]>
---
v2:
- Remove GPL license boilerplate
---
crypto/crct10dif_common.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/crypto/crct10dif_common.c b/crypto/crct10dif_common.c
index b2fab366f518..28a0cdde9449 100644
--- a/crypto/crct10dif_common.c
+++ b/crypto/crct10dif_common.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Cryptographic API.
*
@@ -7,21 +8,6 @@
* Written by Martin K. Petersen <[email protected]>
* Copyright (C) 2013 Intel Corporation
* Author: Tim Chen <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by the Free
- * Software Foundation; either version 2 of the License, or (at your option)
- * any later version.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
- * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
- * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
- * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
*/
#include <linux/crc-t10dif.h>
base-commit: 9561de3a55bed6bdd44a12820ba81ec416e705a7
--
2.39.2 (Apple Git-143)
On Wed, Jun 07, 2023 at 10:50:11AM +0700, Bagas Sanjaya wrote:
> On Tue, Jun 06, 2023 at 08:07:13PM +0200, Franziska Naepelt wrote:
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > /*
> > * Cryptographic API.
> > *
> > @@ -7,21 +8,6 @@
> > * Written by Martin K. Petersen <[email protected]>
> > * Copyright (C) 2013 Intel Corporation
> > * Author: Tim Chen <[email protected]>
> > - *
> > - * This program is free software; you can redistribute it and/or modify it
> > - * under the terms of the GNU General Public License as published by the Free
> > - * Software Foundation; either version 2 of the License, or (at your option)
> > - * any later version.
> > - *
> > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > - * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
> > - * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> > - * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> > - * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> > - * SOFTWARE.
> > - *
> > */
>
> LGTM but I'll send a SPDX conversion series for crypto/ instead soon.
>
OK, here's the series [1].
[1]: https://lore.kernel.org/lkml/[email protected]/
--
An old man doll... just what I always wanted! - Clara
On Tue, Jun 06, 2023 at 08:07:13PM +0200, Franziska Naepelt wrote:
> Fix the following checkpatch warning:
> - WARNING: Missing or malformed SPDX-License-Identifier tag
>
> Signed-off-by: Franziska Naepelt <[email protected]>
> ---
> v2:
> - Remove GPL license boilerplate
> ---
> crypto/crct10dif_common.c | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/crypto/crct10dif_common.c b/crypto/crct10dif_common.c
> index b2fab366f518..28a0cdde9449 100644
> --- a/crypto/crct10dif_common.c
> +++ b/crypto/crct10dif_common.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Cryptographic API.
> *
> @@ -7,21 +8,6 @@
> * Written by Martin K. Petersen <[email protected]>
> * Copyright (C) 2013 Intel Corporation
> * Author: Tim Chen <[email protected]>
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License as published by the Free
> - * Software Foundation; either version 2 of the License, or (at your option)
> - * any later version.
> - *
> - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> - * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
> - * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> - * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> - * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> - * SOFTWARE.
> - *
> */
As the text you removed does not match GPLv2 exactly I'm dropping
this patch for now.
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt