2023-08-02 09:42:54

by Yang Yingliang

Subject: [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree()

Use kfree_sensitive() instead of memset() and kfree().

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/crypto/intel/qat/qat_common/qat_compression.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/intel/qat/qat_common/qat_compression.c b/drivers/crypto/intel/qat/qat_common/qat_compression.c
index 3f1f35283266..7842a9f22178 100644
--- a/drivers/crypto/intel/qat/qat_common/qat_compression.c
+++ b/drivers/crypto/intel/qat/qat_common/qat_compression.c
@@ -234,8 +234,7 @@ static void qat_free_dc_data(struct adf_accel_dev *accel_dev)

dma_unmap_single(dev, dc_data->ovf_buff_p, dc_data->ovf_buff_sz,
DMA_FROM_DEVICE);
- memset(dc_data->ovf_buff, 0, dc_data->ovf_buff_sz);
- kfree(dc_data->ovf_buff);
+ kfree_sensitive(dc_data->ovf_buff);
devm_kfree(dev, dc_data);
accel_dev->dc_data = NULL;
}
--
2.25.1

2023-08-03 09:52:01

by Cabiddu, Giovanni

Subject: Re: [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree()

On Wed, Aug 02, 2023 at 05:14:27PM +0800, Yang Yingliang wrote:
> Use kfree_sensitive() instead of memset() and kfree().
>
> Signed-off-by: Yang Yingliang <[email protected]>
Acked-by: Giovanni Cabiddu <[email protected]>

2023-08-11 11:39:10

by Herbert Xu

Subject: Re: [PATCH -next] crypto: qat - use kfree_sensitive instead of memset/kfree()

On Wed, Aug 02, 2023 at 05:14:27PM +0800, Yang Yingliang wrote:
> Use kfree_sensitive() instead of memset() and kfree().
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/crypto/intel/qat/qat_common/qat_compression.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt