2023-08-07 14:24:12

by Alexey Romanov

[permalink] [raw]
Subject: [PATCH v2 2/3] dt-bindings: rng: meson: add meson-rng-s4 compatible

Now the driver has a separate algo for S4 SoC.

Signed-off-by: Alexey Romanov <[email protected]>
---
Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
index 457a6e43d810..afa52af442a7 100644
--- a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
+++ b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
@@ -14,6 +14,7 @@ properties:
compatible:
enum:
- amlogic,meson-rng
+ - amlogic,meson-s4-rng

reg:
maxItems: 1
--
2.38.1



2023-08-08 16:08:09

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] dt-bindings: rng: meson: add meson-rng-s4 compatible

On Mon, Aug 07, 2023 at 04:06:10PM +0300, Alexey Romanov wrote:
> Now the driver has a separate algo for S4 SoC.
>
> Signed-off-by: Alexey Romanov <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> ---
> Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
> index 457a6e43d810..afa52af442a7 100644
> --- a/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
> +++ b/Documentation/devicetree/bindings/rng/amlogic,meson-rng.yaml
> @@ -14,6 +14,7 @@ properties:
> compatible:
> enum:
> - amlogic,meson-rng
> + - amlogic,meson-s4-rng
>
> reg:
> maxItems: 1
> --
> 2.38.1
>


Attachments:
(No filename) (880.00 B)
signature.asc (235.00 B)
Download all attachments

2023-08-08 16:48:11

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] dt-bindings: rng: meson: add meson-rng-s4 compatible

On Tue, Aug 08, 2023 at 01:09:45PM +0100, Conor Dooley wrote:
> On Mon, Aug 07, 2023 at 04:06:10PM +0300, Alexey Romanov wrote:
> > Now the driver has a separate algo for S4 SoC.
> >
> > Signed-off-by: Alexey Romanov <[email protected]>
>
> Acked-by: Conor Dooley <[email protected]>

Actually, one comment, please, for bindings, write commit messages that
relate to the hardware rather than drivers. The bindings describe the
hardware, after all.


Attachments:
(No filename) (477.00 B)
signature.asc (235.00 B)
Download all attachments