2023-08-11 21:12:42

by Konrad Dybcio

Subject: [PATCH 2/3] crypto: qcom-rng: Make the core clock optional regardless of ACPI presence

Some newer SoCs (like SM8450) do not require a clock vote for the PRNG
to function. Make it entirely optional and rely on the bindings checker
to ensure platforms that need it, consume one.

Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/crypto/qcom-rng.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
index 72dd1a4ebac4..825a729f205e 100644
--- a/drivers/crypto/qcom-rng.c
+++ b/drivers/crypto/qcom-rng.c
@@ -173,13 +173,9 @@ static int qcom_rng_probe(struct platform_device *pdev)
if (IS_ERR(rng->base))
return PTR_ERR(rng->base);

- /* ACPI systems have clk already on, so skip clk_get */
- if (!has_acpi_companion(&pdev->dev)) {
- rng->clk = devm_clk_get(&pdev->dev, "core");
- if (IS_ERR(rng->clk))
- return PTR_ERR(rng->clk);
- }
-
+ rng->clk = devm_clk_get_optional(&pdev->dev, "core");
+ if (IS_ERR(rng->clk))
+ return PTR_ERR(rng->clk);

rng->skip_init = (unsigned long)device_get_match_data(&pdev->dev);


--
2.41.0

2023-08-14 03:02:46

by Bjorn Andersson

Subject: Re: [PATCH 2/3] crypto: qcom-rng: Make the core clock optional regardless of ACPI presence

On Fri, Aug 11, 2023 at 10:50:57PM +0200, Konrad Dybcio wrote:
> Some newer SoCs (like SM8450) do not require a clock vote for the PRNG
> to function. Make it entirely optional and rely on the bindings checker
> to ensure platforms that need it, consume one.
>
> Signed-off-by: Konrad Dybcio <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn