2023-09-25 15:58:05

by Fabio Estevam

[permalink] [raw]
Subject: [PATCH v2 1/3] dt-bindings: crypto: fsl-imx-sahara: Shorten the title

From: Fabio Estevam <[email protected]>

In the title, there is no need to mention "included in some i.MX chips"
as it is too vague.

Remove it to make it simpler.

While at it, also remove the extra space in the first reg entry.

Signed-off-by: Fabio Estevam <[email protected]>
---
Changes since v1:
- Squash the removal of leading space. (Krzysztof)

Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
index d531f3af3ea4..bad82491cd6a 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/crypto/fsl-imx-sahara.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

-title: Freescale SAHARA Cryptographic Accelerator included in some i.MX chips
+title: Freescale SAHARA Cryptographic Accelerator

maintainers:
- Steffen Trumtrar <[email protected]>
@@ -32,6 +32,6 @@ examples:
- |
crypto@10025000 {
compatible = "fsl,imx27-sahara";
- reg = < 0x10025000 0x800>;
+ reg = <0x10025000 0x800>;
interrupts = <75>;
};
--
2.34.1


2023-09-25 21:08:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: fsl-imx-sahara: Shorten the title

On 25/09/2023 13:12, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> In the title, there is no need to mention "included in some i.MX chips"
> as it is too vague.
>
> Remove it to make it simpler.
>
> While at it, also remove the extra space in the first reg entry.
>


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-09-25 22:16:05

by Fabio Estevam

[permalink] [raw]
Subject: [PATCH v2 2/3] dt-bindings: crypto: fsl-imx-sahara: Document the clocks

From: Fabio Estevam <[email protected]>

Describe the clocks (ipg and ahb) needed by Sahara block to operate.

Signed-off-by: Fabio Estevam <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
- Simplify the commit log. (Krzysztof)

.../bindings/crypto/fsl-imx-sahara.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
index bad82491cd6a..9dbfc15510a8 100644
--- a/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
+++ b/Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml
@@ -21,17 +21,34 @@ properties:
interrupts:
maxItems: 1

+ clocks:
+ items:
+ - description: Sahara IPG clock
+ - description: Sahara AHB clock
+
+ clock-names:
+ items:
+ - const: ipg
+ - const: ahb
+
required:
- compatible
- reg
- interrupts
+ - clocks
+ - clock-names

additionalProperties: false

examples:
- |
+ #include <dt-bindings/clock/imx27-clock.h>
+
crypto@10025000 {
compatible = "fsl,imx27-sahara";
reg = <0x10025000 0x800>;
interrupts = <75>;
+ clocks = <&clks IMX27_CLK_SAHARA_IPG_GATE>,
+ <&clks IMX27_CLK_SAHARA_AHB_GATE>;
+ clock-names = "ipg", "ahb";
};
--
2.34.1

2023-10-05 17:33:47

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] dt-bindings: crypto: fsl-imx-sahara: Shorten the title

On Mon, Sep 25, 2023 at 08:12:18AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> In the title, there is no need to mention "included in some i.MX chips"
> as it is too vague.
>
> Remove it to make it simpler.
>
> While at it, also remove the extra space in the first reg entry.
>
> Signed-off-by: Fabio Estevam <[email protected]>
> ---
> Changes since v1:
> - Squash the removal of leading space. (Krzysztof)
>
> Documentation/devicetree/bindings/crypto/fsl-imx-sahara.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt