2023-10-15 19:40:12

by Om Prakash Singh

[permalink] [raw]
Subject: [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280

Add device-tree nodes to enable TRNG for SA8775P and SC7280

*** BLURB HERE ***

Om Prakash Singh (4):
dt-bindings: crypto: qcom,prng: document SA8775P
dt-bindings: crypto: qcom,prng: document SC7280
arm64: dts: qcom: sa8775p: add TRNG node
arm64: dts: qcom: sc7280: add TRNG node

Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 2 ++
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 +++++
3 files changed, 12 insertions(+)

--
2.25.1


2023-10-15 19:40:12

by Om Prakash Singh

[permalink] [raw]
Subject: [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280

Document SC7280 compatible for the True Random Number Generator.

Signed-off-by: Om Prakash Singh <[email protected]>
---
Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 85e6b1c199f5..d52355fbd1d6 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -20,6 +20,7 @@ properties:
- qcom,sm8450-trng
- qcom,sm8550-trng
- qcom,sa8775p-trng
+ - qcom,sc7280-trng
- const: qcom,trng

reg:
--
2.25.1

2023-10-15 19:40:13

by Om Prakash Singh

[permalink] [raw]
Subject: [PATCH V1 4/4] arm64: dts: qcom: sc7280: add TRNG node

The sc7280 SoC has a True Random Number Generator, add the node with
the correct compatible set.

Signed-off-by: Om Prakash Singh <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 925428a5f6ae..dc4332296a3e 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -5368,6 +5368,11 @@ cpufreq_hw: cpufreq@18591000 {
#freq-domain-cells = <1>;
#clock-cells = <1>;
};
+
+ rng: rng@10d3000 {
+ compatible = "qcom,sc7280-trng", "qcom,trng";
+ reg = <0 0x10d3000 0 0x1000>;
+ };
};

thermal_zones: thermal-zones {
--
2.25.1

2023-10-15 19:40:14

by Om Prakash Singh

[permalink] [raw]
Subject: [PATCH V1 3/4] arm64: dts: qcom: sa8775p: add TRNG node

The sa8775p SoC has a True Random Number Generator, add the node with
the correct compatible set.

Signed-off-by: Om Prakash Singh <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 9f4f58e831a4..874780b42a68 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -2391,6 +2391,11 @@ ethernet0: ethernet@23040000 {

status = "disabled";
};
+
+ rng: rng@10d2000 {
+ compatible = "qcom,sa8775p-trng", "qcom,trng";
+ reg = <0 0x10d2000 0 0x1000>;
+ };
};

arch_timer: timer {
--
2.25.1

2023-10-16 03:28:32

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280


On Mon, 16 Oct 2023 01:08:57 +0530, Om Prakash Singh wrote:
> Add device-tree nodes to enable TRNG for SA8775P and SC7280
>
> *** BLURB HERE ***
>
> Om Prakash Singh (4):
> dt-bindings: crypto: qcom,prng: document SA8775P
> dt-bindings: crypto: qcom,prng: document SC7280
> arm64: dts: qcom: sa8775p: add TRNG node
> arm64: dts: qcom: sc7280: add TRNG node
>
> [...]

Applied, thanks!

[3/4] arm64: dts: qcom: sa8775p: add TRNG node
commit: 2d04f31103921b8c21756ff9eeba32e3ece1a276
[4/4] arm64: dts: qcom: sc7280: add TRNG node
commit: d9f33f465114b8d1ecbd5d0b5a4d5f7e709094d9

Best regards,
--
Bjorn Andersson <[email protected]>

2023-10-16 05:24:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH V1 2/4] dt-bindings: crypto: qcom,prng: document SC7280

On 16/10/2023 07:23, Krzysztof Kozlowski wrote:
> On 15/10/2023 21:38, Om Prakash Singh wrote:
>> Document SC7280 compatible for the True Random Number Generator.
>>
>> Signed-off-by: Om Prakash Singh <[email protected]>
>> ---
>> Documentation/devicetree/bindings/crypto/qcom,prng.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> index 85e6b1c199f5..d52355fbd1d6 100644
>> --- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> +++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - qcom,sm8450-trng
>> - qcom,sm8550-trng
>> - qcom,sa8775p-trng
>> + - qcom,sc7280-trng
>
> sc comes before sm

also, this should be squashed with previous patch.

Best regards,
Krzysztof

2023-10-17 16:29:42

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH V1 0/4] Enable TRNG for SA8775P and SC7280



On 10/15/23 21:38, Om Prakash Singh wrote:
> Add device-tree nodes to enable TRNG for SA8775P and SC7280
>
> *** BLURB HERE ***
Generally you want to delete this :)

Konrad