2024-03-06 07:29:50

by Roman Smirnov

Subject: [PATCH] crypto: algboss: remove NULL check in cryptomgr_schedule_probe()

The variable i will never be zero, so the check can be removed.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Signed-off-by: Roman Smirnov <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
---
crypto/algboss.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/crypto/algboss.c b/crypto/algboss.c
index 0de1e6697949..1aa5f306998a 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -138,9 +138,6 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
goto err_free_param;
}

- if (!i)
- goto err_free_param;
-
param->tb[i + 1] = NULL;

param->type.attr.rta_len = sizeof(param->type);
--
2.34.1

2024-03-28 10:22:33

by Herbert Xu

Subject: Re: [PATCH] crypto: algboss: remove NULL check in cryptomgr_schedule_probe()

On Wed, Mar 06, 2024 at 10:29:08AM +0300, Roman Smirnov wrote:
> The variable i will never be zero, so the check can be removed.
>
> Found by Linux Verification Center (linuxtesting.org) with Svace.

Are you sure about this? It does not seem obvious that i cannot
be zero. If the tool is correct you need to provide the reasoning
for it.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt