2024-04-01 12:24:52

by Roman Smirnov

[permalink] [raw]
Subject: [PATCH v2] crypto: algboss: remove NULL check in cryptomgr_schedule_probe()

The for loop will be executed at least once, so i > 0. If the loop
is interrupted before i is incremented (e.g., when checking len for NULL),
i will not be checked.

Found by Linux Verification Center (linuxtesting.org) with Svace.

Signed-off-by: Roman Smirnov <[email protected]>
Reviewed-by: Sergey Shtylyov <[email protected]>
---
crypto/algboss.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/crypto/algboss.c b/crypto/algboss.c
index 0de1e6697949..1aa5f306998a 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -138,9 +138,6 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
goto err_free_param;
}

- if (!i)
- goto err_free_param;
-
param->tb[i + 1] = NULL;

param->type.attr.rta_len = sizeof(param->type);
--
2.34.1