2015-11-17 12:36:49

by Cyrille Pitchen

[permalink] [raw]
Subject: [PATCH 1/1] crypto: tcrypt: fix keysize argument of test_aead_speed for gcm(aes)

The key sizes used by AES in GCM mode should be 128, 192 or 256 bits (16,
24 or 32 bytes).
There is no additional 4byte nonce as for RFC 4106.

Signed-off-by: Cyrille Pitchen <[email protected]>
---
crypto/tcrypt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 46a4a757d478..270bc4b82bd9 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -1789,7 +1789,7 @@ static int do_test(const char *alg, u32 type, u32 mask, int m)
test_aead_speed("rfc4106(gcm(aes))", ENCRYPT, sec,
NULL, 0, 16, 16, aead_speed_template_20);
test_aead_speed("gcm(aes)", ENCRYPT, sec,
- NULL, 0, 16, 8, aead_speed_template_20);
+ NULL, 0, 16, 8, speed_template_16_24_32);
break;

case 212:
--
1.8.2.2


2015-11-23 13:02:11

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 1/1] crypto: tcrypt: fix keysize argument of test_aead_speed for gcm(aes)

On Tue, Nov 17, 2015 at 01:37:10PM +0100, Cyrille Pitchen wrote:
> The key sizes used by AES in GCM mode should be 128, 192 or 256 bits (16,
> 24 or 32 bytes).
> There is no additional 4byte nonce as for RFC 4106.
>
> Signed-off-by: Cyrille Pitchen <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt