2024-05-18 13:08:06

by James Bottomley

[permalink] [raw]
Subject: Re: [PATCH] crypto: api - Do not load modules until algapi is ready

On May 18, 2024 5:32:56 AM PDT, Herbert Xu <[email protected]> wrote:
>On Sat, May 18, 2024 at 02:04:18PM +0300, Jarkko Sakkinen wrote:
>>
>> Right does this mean for TPM driver that a crypto API invocation not
>> having everthing needed loaded will block until this is not the case?
>
>All this does is disable module loading by the Crypto API (because
>there is no point and it may deadlock) until such a point where
>all/most drivers have finished loading.
>
>So if the algorithm is missing (which shouldn't happen because of
>Kconfig selects), then it will simply fail.

I have a curiosity question: if Eric is right and it's looking for an optional hmac accelerator module, why don't I see this? The only real config difference between what I tested and what Nicholas did is he's arm and I'm x86.

James

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.