2019-10-11 12:46:37

by Yunfeng Ye

Subject: [PATCH] crypto: chtls - remove the redundant check in chtls_recvmsg()

A warning message reported by a static analysis tool:
"
Either the condition 'if(skb)' is redundant or there is possible null
pointer dereference: skb.
"

Remove the unused redundant check.

Signed-off-by: Yunfeng Ye <[email protected]>
---
drivers/crypto/chelsio/chtls/chtls_io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c
index 0891ab8..0125f4e 100644
--- a/drivers/crypto/chelsio/chtls/chtls_io.c
+++ b/drivers/crypto/chelsio/chtls/chtls_io.c
@@ -1841,8 +1841,7 @@ int chtls_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
tp->urg_data = 0;

if (avail + offset >= skb->len) {
- if (likely(skb))
- chtls_free_skb(sk, skb);
+ chtls_free_skb(sk, skb);
buffers_freed++;

if (copied >= target &&
--
2.7.4.3

2019-10-19 07:56:17

by Herbert Xu

Subject: Re: [PATCH] crypto: chtls - remove the redundant check in chtls_recvmsg()

On Fri, Oct 11, 2019 at 08:44:53PM +0800, Yunfeng Ye wrote:
> A warning message reported by a static analysis tool:
> "
> Either the condition 'if(skb)' is redundant or there is possible null
> pointer dereference: skb.
> "
>
> Remove the unused redundant check.
>
> Signed-off-by: Yunfeng Ye <[email protected]>
> ---
> drivers/crypto/chelsio/chtls/chtls_io.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt