2022-12-21 09:14:23

by Jia Jie Ho

Subject: [PATCH 1/3] dt-bindings: rng: Add StarFive TRNG module

Add documentation to describe Starfive true random number generator
module.

Co-developed-by: Jenny Zhang <[email protected]>
Signed-off-by: Jenny Zhang <[email protected]>
Signed-off-by: Jia Jie Ho <[email protected]>
---
.../bindings/rng/starfive,jh7110-trng.yaml | 55 +++++++++++++++++++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml

diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
new file mode 100644
index 000000000000..2b76ce25acc4
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rng/starfive,jh7110-trng.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: StarFive SoC TRNG Module
+
+maintainers:
+ - Jia Jie Ho <[email protected]>
+
+properties:
+ compatible:
+ const: starfive,jh7110-trng
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Hardware reference clock
+ - description: AHB reference clock
+
+ clock-names:
+ items:
+ - const: hclk
+ - const: ahb
+
+ resets:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - resets
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ rng: rng@1600C000 {
+ compatible = "starfive,jh7110-trng";
+ reg = <0x1600C000 0x4000>;
+ clocks = <&clk 15>, <&clk 16>;
+ clock-names = "hclk", "ahb";
+ resets = <&reset 3>;
+ interrupts = <30>;
+ };
+...
--
2.25.1

2022-12-21 09:52:41

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/3] dt-bindings: rng: Add StarFive TRNG module

On 21/12/2022 10:08, Jia Jie Ho wrote:
> Add documentation to describe Starfive true random number generator
> module.
>
> Co-developed-by: Jenny Zhang <[email protected]>
> Signed-off-by: Jenny Zhang <[email protected]>
> Signed-off-by: Jia Jie Ho <[email protected]>
> ---
> .../bindings/rng/starfive,jh7110-trng.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-12-22 08:20:11

by Jia Jie Ho

Subject: RE: [PATCH 1/3] dt-bindings: rng: Add StarFive TRNG module

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Wednesday, December 21, 2022 5:48 PM
> To: JiaJie Ho <[email protected]>; Olivia Mackall
> <[email protected]>; Herbert Xu <[email protected]>; Rob
> Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>
> Cc: Emil Renner Berthing <[email protected]>; Conor Dooley
> <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-
> [email protected]
> Subject: Re: [PATCH 1/3] dt-bindings: rng: Add StarFive TRNG module
>
> On 21/12/2022 10:08, Jia Jie Ho wrote:
> > Add documentation to describe Starfive true random number generator
> > module.
> >
> > Co-developed-by: Jenny Zhang <[email protected]>
> > Signed-off-by: Jenny Zhang <[email protected]>
> > Signed-off-by: Jia Jie Ho <[email protected]>
> > ---
> > .../bindings/rng/starfive,jh7110-trng.yaml | 55 +++++++++++++++++++
> > 1 file changed, 55 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> >
>
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
Hi Krzysztof,

Thank you for spending time reviewing this patch.

Best regards,
Jia Jie