2021-11-12 11:03:33

by Julia Lawall

[permalink] [raw]
Subject: [PATCH] crypto: fix flexible_array.cocci warnings

From: kernel test robot <[email protected]>

Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
Signed-off-by: Julia Lawall <[email protected]>
---

tree: https://github.com/meghadey/crypto crypto-avx512
head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 weeks ago
:::::: commit date: 7 weeks ago

aesni-intel_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
u64 partial_block_len;
u64 unused;
/* Allocate space for hash_keys later */
- u8 hash_keys[0];
+ u8 hash_keys[];
};

asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,


2021-11-20 04:07:11

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: fix flexible_array.cocci warnings

On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
> From: kernel test robot <[email protected]>
>
> Zero-length and one-element arrays are deprecated, see
> Documentation/process/deprecated.rst
> Flexible-array members should be used instead.
>
> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: kernel test robot <[email protected]>
> Signed-off-by: Julia Lawall <[email protected]>
> ---
>
> tree: https://github.com/meghadey/crypto crypto-avx512
> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
> :::::: branch date: 7 weeks ago
> :::::: commit date: 7 weeks ago
>
> aesni-intel_glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -87,7 +87,7 @@ struct gcm_context_data {
> u64 partial_block_len;
> u64 unused;
> /* Allocate space for hash_keys later */
> - u8 hash_keys[0];
> + u8 hash_keys[];

Which tree did this come from? Not only is this not zero in my
tree, but it seems to have never been zero in the git history.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2021-11-24 03:17:30

by Chen, Rong A

[permalink] [raw]
Subject: Re: [kbuild-all] Re: [PATCH] crypto: fix flexible_array.cocci warnings

Hi Herbert,

On 11/20/2021 12:06 PM, Herbert Xu wrote:
> On Fri, Nov 12, 2021 at 11:56:22AM +0100, Julia Lawall wrote:
>> From: kernel test robot <[email protected]>
>>
>> Zero-length and one-element arrays are deprecated, see
>> Documentation/process/deprecated.rst
>> Flexible-array members should be used instead.
>>
>> Generated by: scripts/coccinelle/misc/flexible_array.cocci
>>
>> Reported-by: kernel test robot <[email protected]>
>> Signed-off-by: kernel test robot <[email protected]>
>> Signed-off-by: Julia Lawall <[email protected]>
>> ---
>>
>> tree: https://github.com/meghadey/crypto crypto-avx512
>> head: 9c8c2ca77f6e2575a130bddb9767d068e1162d71
>> commit: 377aede9f10ee28be954473668bc6d33c6c9db75 [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ

Sorry for the noise, this patch tries to fix the above commit, it seems
the commit is still in the private tree, we have fixed it to avoid
sending to maintainers.

Best Regards,
Rong Chen

>> :::::: branch date: 7 weeks ago
>> :::::: commit date: 7 weeks ago
>>
>> aesni-intel_glue.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/x86/crypto/aesni-intel_glue.c
>> +++ b/arch/x86/crypto/aesni-intel_glue.c
>> @@ -87,7 +87,7 @@ struct gcm_context_data {
>> u64 partial_block_len;
>> u64 unused;
>> /* Allocate space for hash_keys later */
>> - u8 hash_keys[0];
>> + u8 hash_keys[];
>
> Which tree did this come from? Not only is this not zero in my
> tree, but it seems to have never been zero in the git history.
>
> Thanks,
>