2024-02-26 09:53:05

by Tudor Ambarus

[permalink] [raw]
Subject: Re: [PATCH v4 03/39] dt-bindings: crypto: add sam9x7 in Atmel AES



On 23.02.2024 19:23, Varshini Rajendran wrote:
> Add DT bindings for atmel AES.
>

This would have deserved a better commit message, I (we) spent a lot of
time deciding whether this is the correct approach.
https://lore.kernel.org/linux-arm-kernel/[email protected]/

> Signed-off-by: Varshini Rajendran <[email protected]>
> Acked-by: Rob Herring <[email protected]>

Anyway:
Reviewed-by: Tudor Ambarus <[email protected]>
> ---
> Changes in v4:
> - Updated Acked-by tag
> ---
> .../devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
> index 0b7383b3106b..7dc0748444fd 100644
> --- a/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
> +++ b/Documentation/devicetree/bindings/crypto/atmel,at91sam9g46-aes.yaml
> @@ -12,7 +12,11 @@ maintainers:
>
> properties:
> compatible:
> - const: atmel,at91sam9g46-aes
> + oneOf:
> + - const: atmel,at91sam9g46-aes
> + - items:
> + - const: microchip,sam9x7-aes
> + - const: atmel,at91sam9g46-aes
>
> reg:
> maxItems: 1