2021-03-04 15:20:44

by Álvaro Fernández Rojas

[permalink] [raw]

Subject: [PATCH v5 1/2] dt-bindings: rng: bcm2835: document reset support

---

Some devices may need to perform a reset before using the RNG, such as the
BCM6368.

Signed-off-by: Álvaro Fernández Rojas <[email protected]>
---
v5: no changes.
v4: pass dt_binding_check.
v3: make resets required if brcm,bcm6368-rng.
v2: document reset support.

.../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
index c147900f9041..11c23e1f6988 100644
--- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
+++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
@@ -37,6 +37,21 @@ required:

additionalProperties: false

+if:
+ properties:
+ compatible:
+ enum:
+ - brcm,bcm6368-rng
+then:
+ properties:
+ resets:
+ maxItems: 1
+ required:
+ - resets
+else:
+ properties:
+ resets: false
+
examples:
- |
rng@7e104000 {
@@ -58,4 +73,6 @@ examples:

clocks = <&periph_clk 18>;
clock-names = "ipsec";
+
+ resets = <&periph_rst 4>;
};
--
2.20.1

2021-03-04 16:52:31

by Nicolas Saenz Julienne

[permalink] [raw]

Subject: Re: [PATCH v5 1/2] dt-bindings: rng: bcm2835: document reset support

---

Sorry Alvaro I missed you sent a v5 already. See my comments in v3.

Regards,
Nicolas

On Thu, 2021-03-04 at 08:33 +0100, Álvaro Fernández Rojas wrote:
> Some devices may need to perform a reset before using the RNG, such as the
> BCM6368.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>
> ---
>  v5: no changes.
>  v4: pass dt_binding_check.
>  v3: make resets required if brcm,bcm6368-rng.
>  v2: document reset support.
>
>  .../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
> index c147900f9041..11c23e1f6988 100644
> --- a/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
> +++ b/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
> @@ -37,6 +37,21 @@ required:
>  
>
>  additionalProperties: false
>  
>
> +if:
> + properties:
> + compatible:
> + enum:
> + - brcm,bcm6368-rng
> +then:
> + properties:
> + resets:
> + maxItems: 1
> + required:
> + - resets
> +else:
> + properties:
> + resets: false
> +
>  examples:
>    - |
>      rng@7e104000 {
> @@ -58,4 +73,6 @@ examples:
>  
>
>          clocks = <&periph_clk 18>;
>          clock-names = "ipsec";
> +
> + resets = <&periph_rst 4>;
>      };

---

Attachments:

signature.asc (499.00 B)
This is a digitally signed message part