Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by kmemleak at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Michal Hocko <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Matthew Wilcox <[email protected]>
---
mm/kmemleak.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 7780cd8..25b977f 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -91,7 +91,6 @@
#include <linux/stacktrace.h>
#include <linux/cache.h>
#include <linux/percpu.h>
-#include <linux/hardirq.h>
#include <linux/bootmem.h>
#include <linux/pfn.h>
#include <linux/mmzone.h>
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by pstore at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: Colin Cross <[email protected]>
Cc: Tony Luck <[email protected]>
---
fs/pstore/platform.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index 2b21d18..25dcef4 100644
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -41,7 +41,6 @@
#include <linux/timer.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
-#include <linux/hardirq.h>
#include <linux/jiffies.h>
#include <linux/workqueue.h>
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by btrfs at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Chris Mason <[email protected]>
Cc: Josef Bacik <[email protected]>
Cc: David Sterba <[email protected]>
Cc: [email protected]
---
fs/btrfs/extent_map.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
index 2e348fb..cced7f1 100644
--- a/fs/btrfs/extent_map.c
+++ b/fs/btrfs/extent_map.c
@@ -2,7 +2,6 @@
#include <linux/err.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
-#include <linux/hardirq.h>
#include "ctree.h"
#include "extent_map.h"
#include "compression.h"
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by vfs at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Alexander Viro <[email protected]>
---
fs/dcache.c | 1 -
fs/file_table.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index f901413..9340e8c 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -32,7 +32,6 @@
#include <linux/swap.h>
#include <linux/bootmem.h>
#include <linux/fs_struct.h>
-#include <linux/hardirq.h>
#include <linux/bit_spinlock.h>
#include <linux/rculist_bl.h>
#include <linux/prefetch.h>
diff --git a/fs/file_table.c b/fs/file_table.c
index 61517f5..dab099e 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -23,7 +23,6 @@
#include <linux/sysctl.h>
#include <linux/percpu_counter.h>
#include <linux/percpu.h>
-#include <linux/hardirq.h>
#include <linux/task_work.h>
#include <linux/ima.h>
#include <linux/swap.h>
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by crypto at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
---
crypto/ablk_helper.c | 1 -
crypto/blkcipher.c | 1 -
crypto/mcryptd.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/crypto/ablk_helper.c b/crypto/ablk_helper.c
index 1441f07..ee52660 100644
--- a/crypto/ablk_helper.c
+++ b/crypto/ablk_helper.c
@@ -28,7 +28,6 @@
#include <linux/crypto.h>
#include <linux/init.h>
#include <linux/module.h>
-#include <linux/hardirq.h>
#include <crypto/algapi.h>
#include <crypto/cryptd.h>
#include <crypto/ablk_helper.h>
diff --git a/crypto/blkcipher.c b/crypto/blkcipher.c
index 6c43a0a..01c0d4a 100644
--- a/crypto/blkcipher.c
+++ b/crypto/blkcipher.c
@@ -18,7 +18,6 @@
#include <crypto/internal/skcipher.h>
#include <crypto/scatterwalk.h>
#include <linux/errno.h>
-#include <linux/hardirq.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/seq_file.h>
diff --git a/crypto/mcryptd.c b/crypto/mcryptd.c
index 4e64726..9fa362c 100644
--- a/crypto/mcryptd.c
+++ b/crypto/mcryptd.c
@@ -26,7 +26,6 @@
#include <linux/sched.h>
#include <linux/sched/stat.h>
#include <linux/slab.h>
-#include <linux/hardirq.h>
#define MCRYPTD_MAX_CPU_QLEN 100
#define MCRYPTD_BATCH 9
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by caif at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Dmitry Tarnyagin <[email protected]>
Cc: "David S. Miller" <[email protected]>
---
net/caif/cfpkt_skbuff.c | 1 -
net/caif/chnl_net.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
index 71b6ab2..38c2b7a 100644
--- a/net/caif/cfpkt_skbuff.c
+++ b/net/caif/cfpkt_skbuff.c
@@ -8,7 +8,6 @@
#include <linux/string.h>
#include <linux/skbuff.h>
-#include <linux/hardirq.h>
#include <linux/export.h>
#include <net/caif/cfpkt.h>
diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c
index 922ac1d..53ecda1 100644
--- a/net/caif/chnl_net.c
+++ b/net/caif/chnl_net.c
@@ -8,7 +8,6 @@
#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
#include <linux/fs.h>
-#include <linux/hardirq.h>
#include <linux/init.h>
#include <linux/module.h>
#include <linux/netdevice.h>
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by openvswitch at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Pravin Shelar <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
---
net/openvswitch/vport-internal_dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index 04a3128..2f47c65 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -16,7 +16,6 @@
* 02110-1301, USA
*/
-#include <linux/hardirq.h>
#include <linux/if_vlan.h>
#include <linux/kernel.h>
#include <linux/netdevice.h>
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Preempt counter APIs have been split out, currently, hardirq.h just
includes irq_enter/exit APIs which are not used by TIPC at all.
So, remove the unused hardirq.h.
Signed-off-by: Yang Shi <[email protected]>
Cc: Jon Maloy <[email protected]>
Cc: Ying Xue <[email protected]>
Cc: "David S. Miller" <[email protected]>
---
net/tipc/core.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/tipc/core.h b/net/tipc/core.h
index 5cc5398..099e072 100644
--- a/net/tipc/core.h
+++ b/net/tipc/core.h
@@ -49,7 +49,6 @@
#include <linux/uaccess.h>
#include <linux/interrupt.h>
#include <linux/atomic.h>
-#include <asm/hardirq.h>
#include <linux/netdevice.h>
#include <linux/in.h>
#include <linux/list.h>
--
1.8.3.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
It looks the email address of Pravin in MAINTAINERS file is obsolete,
sent to the right address.
Yang
On 11/17/17 3:02 PM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by openvswitch at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Pravin Shelar <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> ---
> net/openvswitch/vport-internal_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
> index 04a3128..2f47c65 100644
> --- a/net/openvswitch/vport-internal_dev.c
> +++ b/net/openvswitch/vport-internal_dev.c
> @@ -16,7 +16,6 @@
> * 02110-1301, USA
> */
>
> -#include <linux/hardirq.h>
> #include <linux/if_vlan.h>
> #include <linux/kernel.h>
> #include <linux/netdevice.h>
>
On Sat, Nov 18, 2017 at 07:02:16AM +0800, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by btrfs at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Chris Mason <[email protected]>
> Cc: Josef Bacik <[email protected]>
> Cc: David Sterba <[email protected]>
> Cc: [email protected]
Acked-by: David Sterba <[email protected]>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
The email to Herbert is returned, resent it.
Yang
On 11/17/17 3:02 PM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by crypto at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
> ---
> crypto/ablk_helper.c | 1 -
> crypto/blkcipher.c | 1 -
> crypto/mcryptd.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/crypto/ablk_helper.c b/crypto/ablk_helper.c
> index 1441f07..ee52660 100644
> --- a/crypto/ablk_helper.c
> +++ b/crypto/ablk_helper.c
> @@ -28,7 +28,6 @@
> #include <linux/crypto.h>
> #include <linux/init.h>
> #include <linux/module.h>
> -#include <linux/hardirq.h>
> #include <crypto/algapi.h>
> #include <crypto/cryptd.h>
> #include <crypto/ablk_helper.h>
> diff --git a/crypto/blkcipher.c b/crypto/blkcipher.c
> index 6c43a0a..01c0d4a 100644
> --- a/crypto/blkcipher.c
> +++ b/crypto/blkcipher.c
> @@ -18,7 +18,6 @@
> #include <crypto/internal/skcipher.h>
> #include <crypto/scatterwalk.h>
> #include <linux/errno.h>
> -#include <linux/hardirq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/seq_file.h>
> diff --git a/crypto/mcryptd.c b/crypto/mcryptd.c
> index 4e64726..9fa362c 100644
> --- a/crypto/mcryptd.c
> +++ b/crypto/mcryptd.c
> @@ -26,7 +26,6 @@
> #include <linux/sched.h>
> #include <linux/sched/stat.h>
> #include <linux/slab.h>
> -#include <linux/hardirq.h>
>
> #define MCRYPTD_MAX_CPU_QLEN 100
> #define MCRYPTD_BATCH 9
>
On Fri, Nov 17, 2017 at 3:02 PM, Yang Shi <[email protected]> wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by pstore at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: Anton Vorontsov <[email protected]>
> Cc: Colin Cross <[email protected]>
> Cc: Tony Luck <[email protected]>
Thanks! I've applied this for -next.
-Kees
> ---
> fs/pstore/platform.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 2b21d18..25dcef4 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -41,7 +41,6 @@
> #include <linux/timer.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>
> -#include <linux/hardirq.h>
> #include <linux/jiffies.h>
> #include <linux/workqueue.h>
>
> --
> 1.8.3.1
>
--
Kees Cook
Pixel Security
On Sat, Nov 18, 2017 at 07:02:18AM +0800, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by crypto at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi folks,
Any comment on this one?
Thanks,
Yang
On 11/17/17 3:02 PM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by vfs at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Alexander Viro <[email protected]>
> ---
> fs/dcache.c | 1 -
> fs/file_table.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/fs/dcache.c b/fs/dcache.c
> index f901413..9340e8c 100644
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -32,7 +32,6 @@
> #include <linux/swap.h>
> #include <linux/bootmem.h>
> #include <linux/fs_struct.h>
> -#include <linux/hardirq.h>
> #include <linux/bit_spinlock.h>
> #include <linux/rculist_bl.h>
> #include <linux/prefetch.h>
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 61517f5..dab099e 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -23,7 +23,6 @@
> #include <linux/sysctl.h>
> #include <linux/percpu_counter.h>
> #include <linux/percpu.h>
> -#include <linux/hardirq.h>
> #include <linux/task_work.h>
> #include <linux/ima.h>
> #include <linux/swap.h>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Hi folks,
Any comment on this one?
Thanks,
Yang
On 11/17/17 3:02 PM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by caif at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Dmitry Tarnyagin <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> ---
> net/caif/cfpkt_skbuff.c | 1 -
> net/caif/chnl_net.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
> index 71b6ab2..38c2b7a 100644
> --- a/net/caif/cfpkt_skbuff.c
> +++ b/net/caif/cfpkt_skbuff.c
> @@ -8,7 +8,6 @@
>
> #include <linux/string.h>
> #include <linux/skbuff.h>
> -#include <linux/hardirq.h>
> #include <linux/export.h>
> #include <net/caif/cfpkt.h>
>
> diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c
> index 922ac1d..53ecda1 100644
> --- a/net/caif/chnl_net.c
> +++ b/net/caif/chnl_net.c
> @@ -8,7 +8,6 @@
> #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
>
> #include <linux/fs.h>
> -#include <linux/hardirq.h>
> #include <linux/init.h>
> #include <linux/module.h>
> #include <linux/netdevice.h>
>
Hi folks,
Any comment on this one?
Thanks,
Yang
On 11/17/17 5:48 PM, Yang Shi wrote:
> It looks the email address of Pravin in MAINTAINERS file is obsolete,
> sent to the right address.
>
> Yang
>
>
> On 11/17/17 3:02 PM, Yang Shi wrote:
>> Preempt counter APIs have been split out, currently, hardirq.h just
>> includes irq_enter/exit APIs which are not used by openvswitch at all.
>>
>> So, remove the unused hardirq.h.
>>
>> Signed-off-by: Yang Shi <[email protected]>
>> Cc: Pravin Shelar <[email protected]>
>> Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/[email protected]>
>> Cc: [email protected]
>> ---
>> net/openvswitch/vport-internal_dev.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/openvswitch/vport-internal_dev.c
>> b/net/openvswitch/vport-internal_dev.c
>> index 04a3128..2f47c65 100644
>> --- a/net/openvswitch/vport-internal_dev.c
>> +++ b/net/openvswitch/vport-internal_dev.c
>> @@ -16,7 +16,6 @@
>> * 02110-1301, USA
>> */
>> -#include <linux/hardirq.h>
>> #include <linux/if_vlan.h>
>> #include <linux/kernel.h>
>> #include <linux/netdevice.h>
>>
Hi folks,
Any comment on this one?
Thanks,
Yang
On 11/17/17 3:02 PM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by TIPC at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Jon Maloy <[email protected]>
> Cc: Ying Xue <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> ---
> net/tipc/core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/tipc/core.h b/net/tipc/core.h
> index 5cc5398..099e072 100644
> --- a/net/tipc/core.h
> +++ b/net/tipc/core.h
> @@ -49,7 +49,6 @@
> #include <linux/uaccess.h>
> #include <linux/interrupt.h>
> #include <linux/atomic.h>
> -#include <asm/hardirq.h>
> #include <linux/netdevice.h>
> #include <linux/in.h>
> #include <linux/list.h>
>
> -----Original Message-----
> From: [email protected] [mailto:netdev-
> [email protected]] On Behalf Of Yang Shi
> Sent: Thursday, December 07, 2017 14:16
> To: [email protected]
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; Jon Maloy
> <[email protected]>; Ying Xue <[email protected]>; David S.
> Miller <[email protected]>
> Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h
>
> Hi folks,
>
> Any comment on this one?
If it compiles it is ok with me. Don't know why it was put there in the first place.
///jon
>
> Thanks,
> Yang
>
>
> On 11/17/17 3:02 PM, Yang Shi wrote:
> > Preempt counter APIs have been split out, currently, hardirq.h just
> > includes irq_enter/exit APIs which are not used by TIPC at all.
> >
> > So, remove the unused hardirq.h.
> >
> > Signed-off-by: Yang Shi <[email protected]>
> > Cc: Jon Maloy <[email protected]>
> > Cc: Ying Xue <[email protected]>
> > Cc: "David S. Miller" <[email protected]>
> > ---
> > net/tipc/core.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072
> > 100644
> > --- a/net/tipc/core.h
> > +++ b/net/tipc/core.h
> > @@ -49,7 +49,6 @@
> > #include <linux/uaccess.h>
> > #include <linux/interrupt.h>
> > #include <linux/atomic.h>
> > -#include <asm/hardirq.h>
> > #include <linux/netdevice.h>
> > #include <linux/in.h>
> > #include <linux/list.h>
> >
On Fri, Dec 08, 2017 at 03:12:52AM +0800, Yang Shi wrote:
> Hi folks,
>
> Any comment on this one?
Applied
On Fri, Nov 17, 2017 at 3:02 PM, Yang Shi <[email protected]> wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by openvswitch at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Pravin Shelar <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: [email protected]
Acked-by: Pravin B Shelar <[email protected]>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
On 12/7/17 11:20 AM, Jon Maloy wrote:
>
>
>> -----Original Message-----
>> From: [email protected] [mailto:netdev-
>> [email protected]] On Behalf Of Yang Shi
>> Sent: Thursday, December 07, 2017 14:16
>> To: [email protected]
>> Cc: [email protected]; [email protected]; linux-
>> [email protected]; [email protected]; Jon Maloy
>> <[email protected]>; Ying Xue <[email protected]>; David S.
>> Miller <[email protected]>
>> Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h
>>
>> Hi folks,
>>
>> Any comment on this one?
>
> If it compiles it is ok with me. Don't know why it was put there in the first place.
Yes, it does compile.
Yang
>
> ///jon
>
>>
>> Thanks,
>> Yang
>>
>>
>> On 11/17/17 3:02 PM, Yang Shi wrote:
>>> Preempt counter APIs have been split out, currently, hardirq.h just
>>> includes irq_enter/exit APIs which are not used by TIPC at all.
>>>
>>> So, remove the unused hardirq.h.
>>>
>>> Signed-off-by: Yang Shi <[email protected]>
>>> Cc: Jon Maloy <[email protected]>
>>> Cc: Ying Xue <[email protected]>
>>> Cc: "David S. Miller" <[email protected]>
>>> ---
>>> net/tipc/core.h | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/net/tipc/core.h b/net/tipc/core.h index 5cc5398..099e072
>>> 100644
>>> --- a/net/tipc/core.h
>>> +++ b/net/tipc/core.h
>>> @@ -49,7 +49,6 @@
>>> #include <linux/uaccess.h>
>>> #include <linux/interrupt.h>
>>> #include <linux/atomic.h>
>>> -#include <asm/hardirq.h>
>>> #include <linux/netdevice.h>
>>> #include <linux/in.h>
>>> #include <linux/list.h>
>>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
On 11/18/2017 07:02 AM, Yang Shi wrote:
> Preempt counter APIs have been split out, currently, hardirq.h just
> includes irq_enter/exit APIs which are not used by TIPC at all.
>
> So, remove the unused hardirq.h.
>
> Signed-off-by: Yang Shi <[email protected]>
> Cc: Jon Maloy <[email protected]>
> Cc: Ying Xue <[email protected]>
> Cc: "David S. Miller" <[email protected]>
Tested-by: Ying Xue <[email protected]>
Acked-by: Ying Xue <[email protected]>
> ---
> net/tipc/core.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/tipc/core.h b/net/tipc/core.h
> index 5cc5398..099e072 100644
> --- a/net/tipc/core.h
> +++ b/net/tipc/core.h
> @@ -49,7 +49,6 @@
> #include <linux/uaccess.h>
> #include <linux/interrupt.h>
> #include <linux/atomic.h>
> -#include <asm/hardirq.h>
> #include <linux/netdevice.h>
> #include <linux/in.h>
> #include <linux/list.h>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Hi David,
Any more comment on this change?
Thanks,
Yang
On 12/7/17 5:40 PM, Ying Xue wrote:
> On 11/18/2017 07:02 AM, Yang Shi wrote:
>> Preempt counter APIs have been split out, currently, hardirq.h just
>> includes irq_enter/exit APIs which are not used by TIPC at all.
>>
>> So, remove the unused hardirq.h.
>>
>> Signed-off-by: Yang Shi <[email protected]>
>> Cc: Jon Maloy <[email protected]>
>> Cc: Ying Xue <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>
> Tested-by: Ying Xue <[email protected]>
> Acked-by: Ying Xue <[email protected]>
>
>> ---
>> net/tipc/core.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/tipc/core.h b/net/tipc/core.h
>> index 5cc5398..099e072 100644
>> --- a/net/tipc/core.h
>> +++ b/net/tipc/core.h
>> @@ -49,7 +49,6 @@
>> #include <linux/uaccess.h>
>> #include <linux/interrupt.h>
>> #include <linux/atomic.h>
>> -#include <asm/hardirq.h>
>> #include <linux/netdevice.h>
>> #include <linux/in.h>
>> #include <linux/list.h>
>>
Hi David,
Any comment is appreciated.
Thanks,
Yang
On 12/7/17 11:27 AM, Pravin Shelar wrote:
> On Fri, Nov 17, 2017 at 3:02 PM, Yang Shi <[email protected]> wrote:
>> Preempt counter APIs have been split out, currently, hardirq.h just
>> includes irq_enter/exit APIs which are not used by openvswitch at all.
>>
>> So, remove the unused hardirq.h.
>>
>> Signed-off-by: Yang Shi <[email protected]>
>> Cc: Pravin Shelar <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>> Cc: [email protected]
>
> Acked-by: Pravin B Shelar <[email protected]>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Hi David,
I'm not sure if CAIF is still maintained by Dmitry Tarnyagin. Do you
have any comment on this one?
Thanks,
Yang
On 12/7/17 11:13 AM, Yang Shi wrote:
> Hi folks,
>
> Any comment on this one?
>
> Thanks,
> Yang
>
>
> On 11/17/17 3:02 PM, Yang Shi wrote:
>> Preempt counter APIs have been split out, currently, hardirq.h just
>> includes irq_enter/exit APIs which are not used by caif at all.
>>
>> So, remove the unused hardirq.h.
>>
>> Signed-off-by: Yang Shi <[email protected]>
>> Cc: Dmitry Tarnyagin <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>> ---
>> net/caif/cfpkt_skbuff.c | 1 -
>> net/caif/chnl_net.c | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
>> index 71b6ab2..38c2b7a 100644
>> --- a/net/caif/cfpkt_skbuff.c
>> +++ b/net/caif/cfpkt_skbuff.c
>> @@ -8,7 +8,6 @@
>> #include <linux/string.h>
>> #include <linux/skbuff.h>
>> -#include <linux/hardirq.h>
>> #include <linux/export.h>
>> #include <net/caif/cfpkt.h>
>> diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c
>> index 922ac1d..53ecda1 100644
>> --- a/net/caif/chnl_net.c
>> +++ b/net/caif/chnl_net.c
>> @@ -8,7 +8,6 @@
>> #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__
>> #include <linux/fs.h>
>> -#include <linux/hardirq.h>
>> #include <linux/init.h>
>> #include <linux/module.h>
>> #include <linux/netdevice.h>
>>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
From: "Yang Shi" <[email protected]>
Date: Fri, 05 Jan 2018 06:46:48 +0800
> Any more comment on this change?
These patches were not really submitted properly.
If you post a series, the series goes to one destination and
one tree.
If they are supposed to go to multiple trees, submit them
individually rather than as a series. With clear indications
in the Subject lines which tree should be taking the patch.
Thank you.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
On 1/5/18 7:17 AM, David Miller wrote:
> From: "Yang Shi" <[email protected]>
> Date: Fri, 05 Jan 2018 06:46:48 +0800
>
>> Any more comment on this change?
>
> These patches were not really submitted properly.
>
> If you post a series, the series goes to one destination and
> one tree.
>
> If they are supposed to go to multiple trees, submit them
> individually rather than as a series. With clear indications
> in the Subject lines which tree should be taking the patch.
Thanks for the comment. I will resend the net patches in a separate
series to you.
Yang
>
> Thank you.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>