On Thu, Sep 12, 2013 at 02:03:41PM +0900, Tetsuo Handa wrote:
> Herbert Xu wrote:
> > This way at least you'll have a working system until your initramfs
> > tool is fixed to do the right thing.
>
> Thank you. But it is module-init-tools-3.9-21.el6_4 in RHEL 6.4.
> We can't wait until Red Hat backports module-init-tools >= 3.11 to RHEL 6.x.
>
> Since most people are already using module-init-tools >= 3.11 and
> there is workaround for my case (i.e. choose built-in), just updating
>
> module-init-tools 0.9.10 # depmod -V
>
> line at "Current Minimal Requirements" in Documentation/Changes will be OK.
The trouble is not all distros will include the softdep modules in
the initramfs. So for now I think we will have to live with a fallback.
Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu wrote:
> The trouble is not all distros will include the softdep modules in
> the initramfs. So for now I think we will have to live with a fallback.
I see.
Herbert Xu wrote:
> OK, can you please try this patch on top of the current tree?
>
> This way at least you'll have a working system until your initramfs
> tool is fixed to do the right thing.
I tested the patch and confirmed that the boot failure was solved.
But arch/x86/crypto/crct10dif-pclmul.ko is not included into initramfs and
therefore we cannot benefit from PCLMULQDQ version.
---------- before applying patch ----------
kernel/arch/x86/crypto/crct10dif-pclmul.ko: kernel/crypto/crct10dif.ko
kernel/crypto/crct10dif.ko:
kernel/drivers/scsi/lpfc/lpfc.ko: kernel/drivers/scsi/scsi_transport_fc.ko kernel/drivers/scsi/scsi_tgt.ko kernel/lib/crc-t10dif.ko
kernel/drivers/scsi/sd_mod.ko: kernel/lib/crc-t10dif.ko
kernel/drivers/scsi/scsi_debug.ko: kernel/lib/crc-t10dif.ko
kernel/lib/crc-t10dif.ko:
---------- before applying patch ----------
---------- after applying patch ----------
kernel/arch/x86/crypto/crct10dif-pclmul.ko: kernel/crypto/crct10dif_common.ko
kernel/crypto/crct10dif_common.ko:
kernel/crypto/crct10dif_generic.ko: kernel/crypto/crct10dif_common.ko
kernel/drivers/scsi/lpfc/lpfc.ko: kernel/drivers/scsi/scsi_transport_fc.ko kernel/drivers/scsi/scsi_tgt.ko kernel/lib/crc-t10dif.ko kernel/crypto/crct10dif_common.ko
kernel/drivers/scsi/sd_mod.ko: kernel/lib/crc-t10dif.ko kernel/crypto/crct10dif_common.ko
kernel/drivers/scsi/scsi_debug.ko: kernel/lib/crc-t10dif.ko kernel/crypto/crct10dif_common.ko
kernel/lib/crc-t10dif.ko: kernel/crypto/crct10dif_common.ko
---------- after applying patch ----------
On Thu, Sep 12, 2013 at 07:20:23PM +0900, Tetsuo Handa wrote:
> Herbert Xu wrote:
> > The trouble is not all distros will include the softdep modules in
> > the initramfs. So for now I think we will have to live with a fallback.
>
> I see.
>
> Herbert Xu wrote:
> > OK, can you please try this patch on top of the current tree?
> >
> > This way at least you'll have a working system until your initramfs
> > tool is fixed to do the right thing.
>
> I tested the patch and confirmed that the boot failure was solved.
>
> But arch/x86/crypto/crct10dif-pclmul.ko is not included into initramfs and
> therefore we cannot benefit from PCLMULQDQ version.
That is expected and is also the status quo. So once the initrd
generation tool is fixed to include softdeps it will work properly.
Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On 09/12/2013 06:29 AM, Herbert Xu wrote:
> On Thu, Sep 12, 2013 at 07:20:23PM +0900, Tetsuo Handa wrote:
>> Herbert Xu wrote:
>>> The trouble is not all distros will include the softdep modules in
>>> the initramfs. So for now I think we will have to live with a fallback.
>> I see.
>>
>> Herbert Xu wrote:
>>> OK, can you please try this patch on top of the current tree?
>>>
>>> This way at least you'll have a working system until your initramfs
>>> tool is fixed to do the right thing.
>> I tested the patch and confirmed that the boot failure was solved.
>>
>> But arch/x86/crypto/crct10dif-pclmul.ko is not included into initramfs and
>> therefore we cannot benefit from PCLMULQDQ version.
> That is expected and is also the status quo. So once the initrd
> generation tool is fixed to include softdeps it will work properly.
>
> Thanks!
I would like to report that I also have the same boot problem on a
RHEL6.4 box with the crypto patch. My workaround is to force kernel
build to have the crc_t10dif code built-in by changing the config file:
4889c4889
< CONFIG_CRYPTO_CRCT10DIF=m
---
> CONFIG_CRYPTO_CRCT10DIF=y
5002c5002
< CONFIG_CRC_T10DIF=m
---
> CONFIG_CRC_T10DIF=y
This solved the boot problem without any additional patch. Do you think
you should consider changing the configuration default to "y" instead of
"m" or doesn't allow the "m" option at all?
Thanks!
Waiman Long wrote:
> I would like to report that I also have the same boot problem on a
> RHEL6.4 box with the crypto patch. My workaround is to force kernel
> build to have the crc_t10dif code built-in by changing the config file:
>
> 4889c4889
> < CONFIG_CRYPTO_CRCT10DIF=m
> ---
> > CONFIG_CRYPTO_CRCT10DIF=y
> 5002c5002
> < CONFIG_CRC_T10DIF=m
> ---
> > CONFIG_CRC_T10DIF=y
>
> This solved the boot problem without any additional patch. Do you think
> you should consider changing the configuration default to "y" instead of
> "m" or doesn't allow the "m" option at all?
That was proposed but not accepted.
https://lkml.org/lkml/2013/7/17/543
You should choose CONFIG_CRYPTO_CRCT10DIF_PCLMUL=y in your kernel config
if your CPU supports PCLMULQDQ.