2014-02-27 11:34:37

by Jingoo Han

Subject: [PATCH] crypto: omap-des - make local functions static

Make omap_des_copy_needed(), omap_des_copy_sgs(), because these
functions are used only in this file.

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/crypto/omap-des.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index 758919e..ec5f131 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -535,7 +535,7 @@ static int omap_des_crypt_dma_stop(struct omap_des_dev *dd)
return err;
}

-int omap_des_copy_needed(struct scatterlist *sg)
+static int omap_des_copy_needed(struct scatterlist *sg)
{
while (sg) {
if (!IS_ALIGNED(sg->offset, 4))
@@ -547,7 +547,7 @@ int omap_des_copy_needed(struct scatterlist *sg)
return 0;
}

-int omap_des_copy_sgs(struct omap_des_dev *dd)
+static int omap_des_copy_sgs(struct omap_des_dev *dd)
{
void *buf_in, *buf_out;
int pages;
--
1.7.10.4

2014-02-28 01:00:02

by Joel Fernandes

Subject: Re: [PATCH] crypto: omap-des - make local functions static

On 02/27/2014 05:34 AM, Jingoo Han wrote:
> Make omap_des_copy_needed(), omap_des_copy_sgs(), because these
> functions are used only in this file.
>
> Signed-off-by: Jingoo Han <[email protected]>

Ok with me,
Acked-by: Joel Fernandes <[email protected]>

> ---
> drivers/crypto/omap-des.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
> index 758919e..ec5f131 100644
> --- a/drivers/crypto/omap-des.c
> +++ b/drivers/crypto/omap-des.c
> @@ -535,7 +535,7 @@ static int omap_des_crypt_dma_stop(struct omap_des_dev *dd)
> return err;
> }
>
> -int omap_des_copy_needed(struct scatterlist *sg)
> +static int omap_des_copy_needed(struct scatterlist *sg)
> {
> while (sg) {
> if (!IS_ALIGNED(sg->offset, 4))
> @@ -547,7 +547,7 @@ int omap_des_copy_needed(struct scatterlist *sg)
> return 0;
> }
>
> -int omap_des_copy_sgs(struct omap_des_dev *dd)
> +static int omap_des_copy_sgs(struct omap_des_dev *dd)
> {
> void *buf_in, *buf_out;
> int pages;
>

2014-03-10 12:21:52

by Herbert Xu

Subject: Re: [PATCH] crypto: omap-des - make local functions static

On Thu, Feb 27, 2014 at 06:59:48PM -0600, Joel Fernandes wrote:
> On 02/27/2014 05:34 AM, Jingoo Han wrote:
> > Make omap_des_copy_needed(), omap_des_copy_sgs(), because these
> > functions are used only in this file.
> >
> > Signed-off-by: Jingoo Han <[email protected]>
>
> Ok with me,
> Acked-by: Joel Fernandes <[email protected]>

Patch applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt