2015-11-06 01:17:23

by Zain Wang

Subject: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

Add Crypto drivers for rk3288 including crypto controller and dma clk.

Signed-off-by: Zain Wang <[email protected]>
---

Changed in v2:
- None

Changed in v1:
- remove the _crypto suffix
- use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"

arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index 6a79c9c..7b7914e 100644
--- a/arch/arm/boot/dts/rk3288.dtsi
+++ b/arch/arm/boot/dts/rk3288.dtsi
@@ -170,6 +170,21 @@
};
};

+ crypto: cypto-controller@ff8a0000 {
+ compatible = "rockchip,rk3288-crypto";
+ reg = <0xff8a0000 0x4000>;
+ interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_CRYPTO>,
+ <&cru HCLK_CRYPTO>,
+ <&cru SCLK_CRYPTO>,
+ <&cru ACLK_DMAC1>;
+ clock-names = "aclk",
+ "hclk",
+ "sclk",
+ "apb_pclk";
+ status = "okay";
+ };
+
reserved-memory {
#address-cells = <1>;
#size-cells = <1>;
--
1.9.1

2015-11-06 02:01:09

by Caesar Wang

Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

the subject should be add the node/info for crypto...

在 2015年11月06日 09:17, Zain Wang 写道:
> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>
> Signed-off-by: Zain Wang <[email protected]>
> ---
>
> Changed in v2:
> - None
>
> Changed in v1:
> - remove the _crypto suffix
> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>
> arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 6a79c9c..7b7914e 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -170,6 +170,21 @@
> };
> };
>
> + crypto: cypto-controller@ff8a0000 {
> + compatible = "rockchip,rk3288-crypto";
> + reg = <0xff8a0000 0x4000>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_CRYPTO>,
> + <&cru HCLK_CRYPTO>,
> + <&cru SCLK_CRYPTO>,
> + <&cru ACLK_DMAC1>;
> + clock-names = "aclk",
> + "hclk",
> + "sclk",
> + "apb_pclk";

I guess you can do this:

clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;

clock-names = "aclk", "hclk", "sclk", "apb_pclk";


> + status = "okay";
> + };
> +
> reserved-memory {
> #address-cells = <1>;
> #size-cells = <1>;


--
Thanks,
Caesar

2015-11-06 09:50:27

by zain

Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

Hi:

On 2015年11月06日 10:00, Caesar Wang wrote:
> the subject should be add the node/info for crypto...
ok! done!
>
> 在 2015年11月06日 09:17, Zain Wang 写道:
>> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>>
>> Signed-off-by: Zain Wang <[email protected]>
>> ---
>>
>> Changed in v2:
>> - None
>>
>> Changed in v1:
>> - remove the _crypto suffix
>> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>>
>> arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi
>> b/arch/arm/boot/dts/rk3288.dtsi
>> index 6a79c9c..7b7914e 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,21 @@
>> };
>> };
>> + crypto: cypto-controller@ff8a0000 {
>> + compatible = "rockchip,rk3288-crypto";
>> + reg = <0xff8a0000 0x4000>;
>> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru ACLK_CRYPTO>,
>> + <&cru HCLK_CRYPTO>,
>> + <&cru SCLK_CRYPTO>,
>> + <&cru ACLK_DMAC1>;
>> + clock-names = "aclk",
>> + "hclk",
>> + "sclk",
>> + "apb_pclk";
>
> I guess you can do this:
>
> clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, <&cru SCLK_CRYPTO>,
> <&cru ACLK_DMAC1>;
>
> clock-names = "aclk", "hclk", "sclk", "apb_pclk";
ok! done!
>
>
>> + status = "okay";
>> + };
>> +
>> reserved-memory {
>> #address-cells = <1>;
>> #size-cells = <1>;
>
>

2015-11-06 10:12:55

by Heiko Stübner

Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang:
> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>
> Signed-off-by: Zain Wang <[email protected]>
> ---
>
> Changed in v2:
> - None
>
> Changed in v1:
> - remove the _crypto suffix
> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>
> arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 6a79c9c..7b7914e 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -170,6 +170,21 @@
> };
> };
>
> + crypto: cypto-controller@ff8a0000 {
> + compatible = "rockchip,rk3288-crypto";
> + reg = <0xff8a0000 0x4000>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_CRYPTO>,
> + <&cru HCLK_CRYPTO>,
> + <&cru SCLK_CRYPTO>,
> + <&cru ACLK_DMAC1>;
> + clock-names = "aclk",
> + "hclk",
> + "sclk",
> + "apb_pclk";
> + status = "okay";
> + };
> +

please move that whole node to the right location. Entries are sorted by
register address (the ff8a0000 should then of course be below i2s@ff890000
and above vop@ff930000)


> reserved-memory {
> #address-cells = <1>;
> #size-cells = <1>;
>

2015-11-06 10:27:33

by Zain Wang

Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

On 2015年11月06日 18:12, Heiko Stuebner wrote:
> Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang:
>> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>>
>> Signed-off-by: Zain Wang <[email protected]>
>> ---
>>
>> Changed in v2:
>> - None
>>
>> Changed in v1:
>> - remove the _crypto suffix
>> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>>
>> arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 6a79c9c..7b7914e 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,21 @@
>> };
>> };
>>
>> + crypto: cypto-controller@ff8a0000 {
>> + compatible = "rockchip,rk3288-crypto";
>> + reg = <0xff8a0000 0x4000>;
>> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru ACLK_CRYPTO>,
>> + <&cru HCLK_CRYPTO>,
>> + <&cru SCLK_CRYPTO>,
>> + <&cru ACLK_DMAC1>;
>> + clock-names = "aclk",
>> + "hclk",
>> + "sclk",
>> + "apb_pclk";
>> + status = "okay";
>> + };
>> +
> please move that whole node to the right location. Entries are sorted by
> register address (the ff8a0000 should then of course be below i2s@ff890000
> and above vop@ff930000)
ok! done!
>
>
>> reserved-memory {
>> #address-cells = <1>;
>> #size-cells = <1>;
>>
>
>
>



_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip