2023-08-10 12:22:45

by GUO Zihua

Subject: [PATCH -next] hwrng: Remove duplicated include

Remove duplicated include of linux/random.h. Resolves checkincludes
message.

Signed-off-by: GUO Zihua <[email protected]>
---
drivers/char/hw_random/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index f34d356fe2c0..ead998ca0c40 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -21,7 +21,6 @@
#include <linux/sched/signal.h>
#include <linux/miscdevice.h>
#include <linux/module.h>
-#include <linux/random.h>
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
--
2.17.1

2023-08-10 12:33:23

by Herbert Xu

Subject: Re: [PATCH -next] hwrng: Remove duplicated include

On Thu, Aug 10, 2023 at 07:58:58PM +0800, GUO Zihua wrote:
> Remove duplicated include of linux/random.h. Resolves checkincludes
> message.
>
> Signed-off-by: GUO Zihua <[email protected]>
> ---
> drivers/char/hw_random/core.c | 1 -
> 1 file changed, 1 deletion(-)

Please sort the header files alphabetically.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2023-08-10 13:29:34

by GUO Zihua

Subject: Re: [PATCH -next] hwrng: Remove duplicated include

On 2023/8/10 20:14, Herbert Xu wrote:
> On Thu, Aug 10, 2023 at 07:58:58PM +0800, GUO Zihua wrote:
>> Remove duplicated include of linux/random.h. Resolves checkincludes
>> message.
>>
>> Signed-off-by: GUO Zihua <[email protected]>
>> ---
>> drivers/char/hw_random/core.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Please sort the header files alphabetically.
>
> Thanks,
Hi Herbert,

Thanks for the incredibly timely reply! A v2 has been sent.

--
Best
GUO Zihua