2020-09-03 12:12:12

by Iuliana Prodan

[permalink] [raw]
Subject: Re: [PATCH 2/4] crypto: caam - Simplify with dev_err_probe()

On 9/2/2020 6:05 PM, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Iuliana Prodan <[email protected]>

> ---
> drivers/crypto/caam/caamalg_qi2.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypto/caam/caamalg_qi2.c
> index 0441e4ff2df2..076c6b04bea9 100644
> --- a/drivers/crypto/caam/caamalg_qi2.c
> +++ b/drivers/crypto/caam/caamalg_qi2.c
> @@ -5115,8 +5115,7 @@ static int dpaa2_caam_probe(struct fsl_mc_device *dpseci_dev)
> /* DPIO */
> err = dpaa2_dpseci_dpio_setup(priv);
> if (err) {
> - if (err != -EPROBE_DEFER)
> - dev_err(dev, "dpaa2_dpseci_dpio_setup() failed\n");
> + dev_err_probe(dev, err, "dpaa2_dpseci_dpio_setup() failed\n");
> goto err_dpio_setup;
> }
>
>