2020-01-08 07:04:37

by Rijo Thomas

Subject: Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee

+linux-crypto

On 07/01/20 8:06 pm, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Currently the memory allocation failure checks on drv_data and
> amdtee are using IS_ERR rather than checking for a null pointer.
> Fix these checks to use the conventional null pointer check.
>
> Addresses-Coverity: ("Dereference null return")
> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Rijo Thomas <[email protected]>

> ---
> drivers/tee/amdtee/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> index 9d0cee1c837f..5fda810c79dc 100644
> --- a/drivers/tee/amdtee/core.c
> +++ b/drivers/tee/amdtee/core.c
> @@ -444,11 +444,11 @@ static int __init amdtee_driver_init(void)
> goto err_fail;
>
> drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
> - if (IS_ERR(drv_data))
> + if (!drv_data)
> return -ENOMEM;
>
> amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
> - if (IS_ERR(amdtee)) {
> + if (!amdtee) {
> rc = -ENOMEM;
> goto err_kfree_drv_data;
> }
>

2020-01-08 07:55:17

by Jens Wiklander

Subject: Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee

On Wed, Jan 8, 2020 at 8:03 AM Thomas, Rijo-john
<[email protected]> wrote:
>
> +linux-crypto
>
> On 07/01/20 8:06 pm, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > Currently the memory allocation failure checks on drv_data and
> > amdtee are using IS_ERR rather than checking for a null pointer.
> > Fix these checks to use the conventional null pointer check.
> >
> > Addresses-Coverity: ("Dereference null return")
> > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Reviewed-by: Rijo Thomas <[email protected]>

Acked-by: Jens Wiklander <[email protected]>

Thanks,
Jens

>
> > ---
> > drivers/tee/amdtee/core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tee/amdtee/core.c b/drivers/tee/amdtee/core.c
> > index 9d0cee1c837f..5fda810c79dc 100644
> > --- a/drivers/tee/amdtee/core.c
> > +++ b/drivers/tee/amdtee/core.c
> > @@ -444,11 +444,11 @@ static int __init amdtee_driver_init(void)
> > goto err_fail;
> >
> > drv_data = kzalloc(sizeof(*drv_data), GFP_KERNEL);
> > - if (IS_ERR(drv_data))
> > + if (!drv_data)
> > return -ENOMEM;
> >
> > amdtee = kzalloc(sizeof(*amdtee), GFP_KERNEL);
> > - if (IS_ERR(amdtee)) {
> > + if (!amdtee) {
> > rc = -ENOMEM;
> > goto err_kfree_drv_data;
> > }
> >

2020-01-16 07:32:09

by Herbert Xu

Subject: Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee

On Wed, Jan 08, 2020 at 12:33:08PM +0530, Thomas, Rijo-john wrote:
> +linux-crypto
>
> On 07/01/20 8:06 pm, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > Currently the memory allocation failure checks on drv_data and
> > amdtee are using IS_ERR rather than checking for a null pointer.
> > Fix these checks to use the conventional null pointer check.
> >
> > Addresses-Coverity: ("Dereference null return")
> > Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Reviewed-by: Rijo Thomas <[email protected]>

This patch needs to be resubmitted to the linux-crypto list for
it to be picked up by patchwork.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2020-01-16 08:55:52

by Rijo Thomas

Subject: Re: [PATCH][next] tee: fix memory allocation failure checks on drv_data and amdtee

Hi Colin,

On 16/01/20 12:35 pm, Herbert Xu wrote:
> On Wed, Jan 08, 2020 at 12:33:08PM +0530, Thomas, Rijo-john wrote:
>> +linux-crypto
>>
>> On 07/01/20 8:06 pm, Colin King wrote:
>>> From: Colin Ian King <[email protected]>
>>>
>>> Currently the memory allocation failure checks on drv_data and
>>> amdtee are using IS_ERR rather than checking for a null pointer.
>>> Fix these checks to use the conventional null pointer check.
>>>
>>> Addresses-Coverity: ("Dereference null return")
>>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
>>> Signed-off-by: Colin Ian King <[email protected]>
>>
>> Reviewed-by: Rijo Thomas <[email protected]>
>
> This patch needs to be resubmitted to the linux-crypto list for
> it to be picked up by patchwork.

Can you please resubmit this patch to linux-crypto list?

Thanks,
Rijo

>
> Thanks,
>