2016-06-30 10:23:51

by Jan Stancek

Subject: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

Parallel build can sporadically fail because asn1 headers may
not be built yet by the time qat_asym_algs.o is compiled:
drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
#include "qat_rsapubkey-asn1.h"

Signed-off-by: Jan Stancek <[email protected]>
Cc: Tadeusz Struk <[email protected]>
Cc: Herbert Xu <[email protected]>
---
drivers/crypto/qat/qat_common/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/qat/qat_common/Makefile b/drivers/crypto/qat/qat_common/Makefile
index 6d74b91f2152..5fc3dbb9ada0 100644
--- a/drivers/crypto/qat/qat_common/Makefile
+++ b/drivers/crypto/qat/qat_common/Makefile
@@ -2,6 +2,7 @@ $(obj)/qat_rsapubkey-asn1.o: $(obj)/qat_rsapubkey-asn1.c \
$(obj)/qat_rsapubkey-asn1.h
$(obj)/qat_rsaprivkey-asn1.o: $(obj)/qat_rsaprivkey-asn1.c \
$(obj)/qat_rsaprivkey-asn1.h
+$(obj)/qat_asym_algs.o: $(obj)/qat_rsapubkey-asn1.h $(obj)/qat_rsaprivkey-asn1.h

clean-files += qat_rsapubkey-asn1.c qat_rsapubkey-asn1.h
clean-files += qat_rsaprivkey-asn1.c qat_rsaprivkey-asn1.h
--
1.8.3.1

2016-07-01 09:32:30

by Herbert Xu

Subject: Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote:
> Parallel build can sporadically fail because asn1 headers may
> not be built yet by the time qat_asym_algs.o is compiled:
> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
> #include "qat_rsapubkey-asn1.h"
>
> Signed-off-by: Jan Stancek <[email protected]>
> Cc: Tadeusz Struk <[email protected]>
> Cc: Herbert Xu <[email protected]>

Jan, Salvatore just posted a patch to delete the qat ASN code
altogether, so your patch won't be needed.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2016-07-20 15:52:20

by Thomas Backlund

Subject: Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

Den 01-07-2016 kl. 12:30, skrev Herbert Xu:
> On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote:
>> Parallel build can sporadically fail because asn1 headers may
>> not be built yet by the time qat_asym_algs.o is compiled:
>> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory
>> #include "qat_rsapubkey-asn1.h"
>>
>> Signed-off-by: Jan Stancek <[email protected]>
>> Cc: Tadeusz Struk <[email protected]>
>> Cc: Herbert Xu <[email protected]>
>
> Jan, Salvatore just posted a patch to delete the qat ASN code
> altogether, so your patch won't be needed.
>
> Thanks,
>

Yeah, but that patch seem to be heading to 4.8 only , so qat build in
upcoming 4.7 still breaks...

and pulling that fix only to 4.7 breaks too, so I guess more fixes
would be needed for proper backport then...

or are the qat fixes already queued somewhere for 4.7 final ?

--
Thomas

2016-07-21 04:14:50

by Herbert Xu

Subject: Re: [PATCH] crypto: qat - make qat_asym_algs.o depend on asn1 headers

On Wed, Jul 20, 2016 at 06:37:07PM +0300, Thomas Backlund wrote:
>
> Yeah, but that patch seem to be heading to 4.8 only , so qat build
> in upcoming 4.7 still breaks...
>
> and pulling that fix only to 4.7 breaks too, so I guess more fixes
> would be needed for proper backport then...
>
> or are the qat fixes already queued somewhere for 4.7 final ?

You're right. This patch is probably the safest fix for 4.7.

I'll bounce it to stable.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt