2017-01-19 21:28:11

by Denys Vlasenko

Subject: [PATCH] x86/crypto: fix %progbits -> @progbits

%progbits form is used on ARM (where @ is a comment char).

x86 consistently uses @progbits everywhere else.

Signed-off-by: Denys Vlasenko <[email protected]>
CC: Herbert Xu <[email protected]>
CC: Josh Poimboeuf <[email protected]>
CC: Xiaodong Liu <[email protected]>
CC: Megha Dey <[email protected]>
CC: George Spelvin <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
---
arch/x86/crypto/crc32c-pcl-intel-asm_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
index dc05f01..7a7de27 100644
--- a/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
+++ b/arch/x86/crypto/crc32c-pcl-intel-asm_64.S
@@ -312,7 +312,7 @@ do_return:
ret
ENDPROC(crc_pcl)

-.section .rodata, "a", %progbits
+.section .rodata, "a", @progbits
################################################################
## jump table Table is 129 entries x 2 bytes each
################################################################
--
2.9.2

2017-01-19 21:32:55

by Josh Poimboeuf

Subject: Re: [PATCH] x86/crypto: fix %progbits -> @progbits

On Thu, Jan 19, 2017 at 10:28:05PM +0100, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
>
> x86 consistently uses @progbits everywhere else.
>
> Signed-off-by: Denys Vlasenko <[email protected]>

Reviewed-by: Josh Poimboeuf <[email protected]>

--
Josh

2017-01-23 15:00:31

by Herbert Xu

Subject: Re: [PATCH] x86/crypto: fix %progbits -> @progbits

On Thu, Jan 19, 2017 at 10:28:05PM +0100, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
>
> x86 consistently uses @progbits everywhere else.
>
> Signed-off-by: Denys Vlasenko <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2017-01-25 22:37:08

by H. Peter Anvin

Subject: Re: [PATCH] x86/crypto: fix %progbits -> @progbits

On 01/19/17 13:28, Denys Vlasenko wrote:
> %progbits form is used on ARM (where @ is a comment char).
>
> x86 consistently uses @progbits everywhere else.

However, it looks like %progbits works on all architectures (at least
include/linux/init.h seems to imply so.) Perhaps a tree-wide
replacement the other way would make more sense.

Personally I would also like to see these parameters macroized, to keep
someone from getting them wrong, just like we have __INIT, __INITRODATA
etc already, we should just have plain __TEXT __DATA __BSS...

-hpa